Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Revise storybook entry for ExternalLinkCard component #5256

Closed
3 tasks done
sunyatasattva opened this issue Nov 25, 2021 · 0 comments · Fixed by #5292
Closed
3 tasks done

Revise storybook entry for ExternalLinkCard component #5256

sunyatasattva opened this issue Nov 25, 2021 · 0 comments · Fixed by #5292
Assignees
@sunyatasattva
Labels
focus: components Work that introduces new or updates existing components. skip-changelog PRs that you don't want to appear in the changelog. type: cooldown Things that are queued for a cooldown period (assists with planning). type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: refactor The issue/PR is related to refactoring. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@sunyatasattva
Copy link
Contributor

sunyatasattva commented Nov 25, 2021 •
edited
Loading

As part of the Storybook resurrection project, we intend to revise our currently implemented components to add full control and, where applicable, a few useful stories.

In particular, for the ExternalLinkCard component:

Controls

  • Href
  • Title
  • Description
@sunyatasattva sunyatasattva added focus: components Work that introduces new or updates existing components. type: refactor The issue/PR is related to refactoring. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. skip-changelog PRs that you don't want to appear in the changelog. type: cooldown Things that are queued for a cooldown period (assists with planning). type: technical debt This issue/PR represents/solves the technical debt of the project. labels Nov 26, 2021
sunyatasattva added a commit that referenced this issue Dec 1, 2021
@sunyatasattva
Fix ExternalLinkCard story (#5256)
3b90c4b
@sunyatasattva sunyatasattva self-assigned this Dec 1, 2021
sunyatasattva added a commit that referenced this issue Dec 1, 2021
@sunyatasattva
Fix ExternalLinkCard story (#5256)
07f2bc2
@sunyatasattva sunyatasattva mentioned this issue Dec 1, 2021
Merged
1 task
sunyatasattva added a commit that referenced this issue Dec 2, 2021
@sunyatasattva
Fix ExternalLinkCard story (#5256) (#5292)
daa1247
jonny-bull pushed a commit to jonny-bull/woocommerce-gutenberg-products-block that referenced this issue Dec 14, 2021
@sunyatasattva @jonny-bull
Fix ExternalLinkCard story (woocommerce#5256) (woocommerce#5292)
3291cc7
jonny-bull pushed a commit to jonny-bull/woocommerce-gutenberg-products-block that referenced this issue Dec 16, 2021
@sunyatasattva @jonny-bull
Fix ExternalLinkCard story (woocommerce#5256) (woocommerce#5292)
cf24e88
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sunyatasattva sunyatasattva

Labels
focus: components Work that introduces new or updates existing components. skip-changelog PRs that you don't want to appear in the changelog. type: cooldown Things that are queued for a cooldown period (assists with planning). type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: refactor The issue/PR is related to refactoring. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Storybook and TS migration of ExternalLinkCard component (#5256) woocommerce/woocommerce-blocks
1 participant
@sunyatasattva