-
Notifications
You must be signed in to change notification settings - Fork 219
UX improvement on Legacy Blocks deletion #5180
Comments
Thank you for writing this up in such a precise and easy-to-follow way, @sunyatasattva!
Just providing the additional context that while locking the block from being removed (
I'd agree with your assessment that this is not preferred and that we should look into addressing the problem in some form.
This would be my preferred solution. That said, I'm not certain it is possible to limit a block to only appearing in the block inserter on specific block templates. We can open another ticket for a research spike to look into this.
See my clarifying comment above. While it is possible to affect the two functions of removing and moving independently of each other, locking the deletion automatically leads to the block not being allowed to be moved inside other blocks. This is something that would need to be solved at the block editor level i.e. in Gutenberg. It's a multi-faceted problem though, as there are good reasons for the current behavior of the block locking feature.
👉 This is probably the most straightforward solution to the issue.
I agree with your assessment that this solution comes with its own set of issues. |
Thanks for summarising our conversation and taking a stab at visualizing a potential solution. While I'd agree that this note is important, I still think that adding a colored background adds too much attention to a shortcoming of what in itself is the first iteration of a new feature that provides merchants with new opportunities. We could explore removing the background and adding the note below the other copy with an empty line between the two.
|
Great write up @sunyatasattva. I don't know much about FSE yet, but I do have some experience with UX, and putting my user hat on, I would agree with you both that there are some issues with displaying a message to a user indicating that the only way to solve their problem is to "delete this template and edit it again". As a user that would make me panic. I would also suggest either discouraging the user from deleting their template as I don't believe it's something they would want to do. We could use words such as "This is a legacy block that is no longer supported. You can remove this block, but you will not be able to add it back". We could also say something like "As an alternative consider X block" if there is an alternative Gutenberg block. Alternatively, if we feel like we want to tell the user to delete the template and edit again, it would be good to be more explicit about the steps and consequences of that action. To me it seems like I'm going to loose a lot of my work on the store. Also like @frontdevde said, this is a temporary situation until the PHP blocks get phased out. It might be re-assuring to the user to know this is temporary, and that it won't be a problem in the future. I would suggest adding to the warning message words to that effect to comfort the user. |
Hey @sunyatasattva! I agree with you and others that #4 is probably the easiest option for now. I would like to progress from these placeholders as quickly as possible in the following stages, so I think this covers our bases. I also don't mind the modal, but I understand that it takes longer dev time and is a temporary fix. I have noticed a lot of text in this block with the new notice, so I'd suggest editing it to make it quicker to digest and comprehend. I know I input on this copy in another issue, but it still could sound very technical to a non-expert. I would be even more explicit in its purpose and rephrase it to say something like: "ATTN: Do not remove this block. This is a placeholder for the WooCommerce Product Archive block template. On your store, this will be displayed as a grid of your product image(s), title, price, etc." That being said, it might be helpful to have something to refer to if the user accidentally deletes the block. But I am not sure the best place for this is in the block itself. It might be useful to have a link to reference "I removed a placeholder block, what do I do?". And also make support aware of this. Also as @frontdevde mentioned above, I think being careful we aren't highlighting a shortcoming is key. Maybe we can link to upcoming plans for the templates? (not sure if we have that somewhere easily accessible). Or if not, we can include "This block template is in development. Keep an eye out for updates!". |
Thanks for writing this up and summarizing the challenges of this issue @sunyatasattva! I agree with everything that has been said in this thread so I don't have much to add, but will leave my two cents below:
As some have already mentioned, realistically it will take some time until those blocks can be completely phased out, so I agree that we need to find a temporary solution until then.
That would be great and seems like a good fit for the Store Editing Templates v2 project, @frontdevde. One interim solution that might be easier to implement is to hide that block from the inserter in the Post/page editor but show it in the Site editor.
That's a good point. I think there might be value in showcasing that those blocks are a temporary replacement for the block templates but in the future they will be deprecated in favor of smaller/more specific blocks. |
Thanks everyone for your thoughtful answers. I especially agree with @vivialice that the copy right now is just too long and should be shortened. I'm absolutely horrible at copywriting, so I'd ask perhaps someone else to come up with a definitive copy for the entire block? Perhaps @nielslange as I see you are marked as a communication domain expert or maybe @vivialice with your UX expertise? I agree with what has been said that this copy should be:
RecapSo, to recap, we agree that our favorite short-term solution is to edit the current block copy, and the longer term solution would be to figure out if we can enable legacy blocks insertions only on certain templates, and the longest term solution is to phase out those blocks. Is that correct? What should the next step be, then? Should this ticket be used to improve the copy, or should we open separate tickets for:
How does this sound? Am I missing something? |
Created a related issue for this task #5193 |
@sunyatasattva Yes :) Could you please create a follow-up issue to address 4. as proposed in this issue and add it to the Store Editing Templates v2 milestone? Thank you!
Done, see #5193 |
Legacy blocks were previous locked for removal to avoid unintended consequences. However, this would lock the ability to move the block within other e.g. layout blocks and unnecessarily limit merchant customization ability. Now that we have reverted this decision, merchants could delete this block, which is likely **not** what they want to do. While we investigate other, more long-term, solutions, we are adding a warning notice. Refs #5180.
Legacy blocks were previous locked for removal to avoid unintended consequences. However, this would lock the ability to move the block within other e.g. layout blocks and unnecessarily limit merchant customization ability. Now that we have reverted this decision, merchants could delete this block, which is likely **not** what they want to do. While we investigate other, more long-term, solutions, we are adding a warning notice. Refs #5180.
Legacy blocks were previous locked for removal to avoid unintended consequences. However, this would lock the ability to move the block within other e.g. layout blocks and unnecessarily limit merchant customization ability. Now that we have reverted this decision, merchants could delete this block, which is likely **not** what they want to do. While we investigate other, more long-term, solutions, we are adding a warning notice. Refs #5180. Fixes #5207. * Rename legacy blocks to avoid confusion with the term “Template”
For full context and history, cfr: #5166, #5176
While we are in the process of phasing out the legacy PHP blocks, an interesting UX question arises in the transition period. With the issues linked above, we have decided to revert our previous judgement to make those blocks locked and un-erasable for the user.
The reasoning was that erasing those blocks was probably not something the users wanted to do, and possibly accidental (or they didn't know the consequences thereof). The side-effect was that these blocks could not be moved either.
With #5176 we decided that disempowering the user to move the blocks just to protect them from themselves was defeating the purpose of FSE. However, legacy blocks do not appear normally on our Block Inserter (because they might not be compatible with the page the user is trying to add them to).
This means that, after an accidental deletion, the user cannot intuitively add the block back.
A workaround currently is to delete the template the user has been working on, and thus reverting to the default override. This workaround has two drawbacks:
This ticket is meant to spark a discussion on what the solutions to this problem might be.
Proposed solutions
DELETE
to confirm your action (Firebase does this). This might be overkill, since in our case it is a reversible action, but it was worth mentioning. The drawbacks of this solution are:All in all, the ideal solution is probably either (2.) or understanding how quickly we can phase those blocks out (so, sort of 1.), but it doesn't seem any timeline would be quick enough, IMHO.
Mockup
I took the liberty of doing a small mockup of my proposed, short-term solution (4.). We discussed a few things with @frontdevde:
Conclusion
I'd appreciate any input on this conversation, even if it is that I'm overstating the danger of such interaction. Also feel free to propose different solutions, and I would probably call in @vivialice to take a look at this and chip in with her opinion.
The text was updated successfully, but these errors were encountered: