Experimental tracking support data for impressions causing slowdown

[notdian]

Product grid appends inject item data to body, this line is not cached at all, when you have multiple product grids (in my case 7 * 12 ) causes over extra un cachable queries.

[nielslange]

Hello @dianfishekqi 👋

Thanks for reporting this issue. Can you provide detailed steps on how to reproduce and monitor the problem that you reported?

[nerrad]

While we'd appreciate more details about the exact problems you are encountering here @dianfishekqi I've taken a brief look at the code path referred to and here's a synopsis. The code being referenced is here:

https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/e00cd017bfd3d30167a9821db5725675a58478f1/src/BlockTypes/AbstractProductGrid.php#L93

While the $products being mapped to the function Automattic\WooCommerce\Blocks\StoreApi\Schemas::get_item_response ARE in fact cached:

https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/e00cd017bfd3d30167a9821db5725675a58478f1/src/BlockTypes/AbstractProductGrid.php#L292-L308

It looks like that each call to Automattic\WooCommerce\Blocks\StoreApi\Schemas::get_item_response results in additional queries for data related to the products (eg get_the_terms). Although it appears that those could be cached as well, so at least the initial query to terms for a given product ID should be the only query made if that product appears in multiple instances of the block.

https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/e00cd017bfd3d30167a9821db5725675a58478f1/src/StoreApi/Schemas/ProductSchema.php#L430-L466

@mikejolley, without having any further data around exactly what the issue author is referring to here, do you think it's worthwhile at least auditing the queries happening through this code stack and seeing if we can optimize more as a potential performance improvement (and add to the backlog)?

[notdian]

Hello all,

SELECT post_id as variation_id, meta_key as attribute_key, meta_value as attribute_value FROM wp_postmeta WHERE post_id IN (25295,25298,25300,25303)AND meta_key IN ('attribute_pa_size') |

one of the queries not being cached debugged on Query Monitor source Automattic\W\B\S\S\ProductSchema>get_variations()

[notdian]

@nerrad It's amounting to 91/121 queries on our homepages.

[notdian]

Commenting it out :

Brings down the number of queries to zero improving page generation time by 70%.

[nerrad]

Thanks! This is something on the list of things we'll look into.

[mikejolley]

There is no evidence that the queries are uncached (which would be reported as duplicate queries in Query Monitor), there are just many similar queries per variable product. We can look at priming them somehow, or revise what is exposed via the experimental action.

Managed to replicate the query issue with multiple duplicate blocks.