Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

replace with $grid-unit values when `@woocommerce/base-st... #3313

Closed
github-actions bot opened this issue Oct 22, 2020 · 0 comments · Fixed by #3457
Closed

replace with $grid-unit values when `@woocommerce/base-st... #3313

github-actions bot opened this issue Oct 22, 2020 · 0 comments · Fixed by #3457
Labels
focus: global styles Issues that involve styles/css/layout structure. type: refactor The issue/PR is related to refactoring.

Comments

@github-actions
Copy link
Contributor

replace with $grid-unit values when `@woocommerce/base-styles` is updated. github.com/WordPress/gutenberg/blob/master/packages/base-styles/_variables.scss#L23-L36 $grid-unit-50


https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/c8de44956cc0071565950bfbac6fb66352897159/assets/css/abstracts/_variables.scss#L3-L14

🚀 This issue was generated by the automations bot based on a todo comment in c8de449 when #3300 was merged. cc @Aljullu
@nerrad nerrad added focus: global styles Issues that involve styles/css/layout structure. type: refactor The issue/PR is related to refactoring. labels Oct 22, 2020
Aljullu added a commit that referenced this issue Dec 3, 2020
…to v. 3.2.0 (#3457)

* Update @wordpress/components and @wordpress/base-styles

* Fix JS warning in Select/downshift

* Remove color definitions that are now imported from @wordpress/base-styles. Fixes #3311

* Use -unit values from @wordpress/base-styles. Fixes #3313

* Update snapshots

* Fix payment methods test

* Don't extract dependencies that are not available in WP 5.3

* Avoid extracting @wordpress/compose since last version doesn't have resize observer

* Remove unnecessary uses of @wordpress/compose in a frontend scripts

* Add missing spaces
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: global styles Issues that involve styles/css/layout structure. type: refactor The issue/PR is related to refactoring.
Projects
None yet
1 participant