Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Products by Attribute block doesn't persist the current values when clicking on edit button #3084

Closed
Aljullu opened this issue Aug 31, 2020 · 0 comments · Fixed by #3185
Closed
Labels
block: products by attribute Issues related to the Products by Attribute block. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Aug 31, 2020

To reproduce

Steps to reproduce the behavior:

  1. Add a Products by Attribute block.
  2. Select some attributes and click on Done.
  3. Click on the pencil icon to edit the block again.
  4. Notice the attributes you previously selected are not checked by default, so it's easy to forget what was your previous attribute selection.

Expected behavior

When clicking on the edit button, the currently selected attributes should be checked by default, like it happens with the Products by Category block, for example.

Screenshots

Peek 2020-08-31 10-40

@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. block: products by attribute Issues related to the Products by Attribute block. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. labels Aug 31, 2020
farookibrahim pushed a commit to farookibrahim/woocommerce-gutenberg-products-block that referenced this issue Sep 23, 2020
senadir pushed a commit that referenced this issue Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: products by attribute Issues related to the Products by Attribute block. type: bug The issue/PR concerns a confirmed bug. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
1 participant