Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Store Customization > Hero Product Split pattern - Update the pattern to become wireframed #10211

Closed
Tracked by #10087
nefeline opened this issue Jul 14, 2023 · 5 comments · Fixed by #10270
Closed
Tracked by #10087
Assignees
Labels
focus: patterns WooCommerce patterns

Comments

@nefeline
Copy link
Contributor

nefeline commented Jul 14, 2023

As decided on #10086 (comment), we need to remove all opinionated styles from the Hero Product Split Pattern, including custom font colors, background, button colors, and any other additional styles (if found).

Screenshot

Screenshot 2023-07-19 at 11 55 35

Designs

Figma: F5AAbRJOGbTeEweXPFtHgf-fi-2242_36072

@nefeline nefeline added the focus: patterns WooCommerce patterns label Jul 14, 2023
@nefeline nefeline self-assigned this Jul 17, 2023
@nefeline
Copy link
Contributor Author

Hey @jarekmorawski ! I just noticed that the pattern that is tagged as Hero Product Split pattern on figma is matching a wireframed version of the Banner Pattern:

Figma:

Screenshot 2023-07-17 at 10 55 29

Banner Pattern:

Screenshot 2023-07-17 at 10 55 29

Hero Product Split pattern:

Screenshot 2023-07-17 at 10 55 29

Could you please confirm if the pattern that needs to be wireframed is the Banner Pattern or the Hero Product Split?

@jarekmorawski
Copy link

Hi @nefeline 👋 These are different patterns. I referenced Hero Product Split because the image extends to the edge of the screen. In Banner, there's a fixed margin-left that is not suitable for a hero pattern. I assume the similarity comes from the 64 px top and bottom margins I added in Figma (the equivalent of block spacing in Global Styles).

@nefeline
Copy link
Contributor Author

@jarekmorawski thanks:

I assume the similarity comes from the 64 px top and bottom margins I added in Figma (the equivalent of block spacing in Global Styles).

The reason I flagged it is that on the Figma design, the text doesn't match what we currently have for the Hero Product Split pattern; it matches what is displayed for the Banner Pattern instead (with the only exception being the button text - see screenshots shared in previous comment over here).

I referenced Hero Product Split because the image extends to the edge of the screen.

Considering Hero Product Split pattern is the one we aim to wireframe, should the text of this pattern be updated as well so it matches the design on Figma?

@jarekmorawski
Copy link

Considering Hero Product Split pattern is the one we aim to wireframe, should the text of this pattern be updated as well so it matches the design on Figma?

No, I'll update the Figma. Thanks for bringing this up! Let's use the copy we already have.

@nefeline
Copy link
Contributor Author

No, I'll update the Figma. Thanks for bringing this up! Let's use the copy we already have.

Excellent, thanks for confirming! 🙌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: patterns WooCommerce patterns
Projects
None yet
2 participants