-
Notifications
You must be signed in to change notification settings - Fork 219
Store Customization > Hero Product Split pattern - Update the pattern to become wireframed #10211
Comments
Hey @jarekmorawski ! I just noticed that the pattern that is tagged as Hero Product Split pattern on figma is matching a wireframed version of the Banner Pattern: Figma: Banner Pattern: Hero Product Split pattern: Could you please confirm if the pattern that needs to be wireframed is the Banner Pattern or the Hero Product Split? |
Hi @nefeline 👋 These are different patterns. I referenced Hero Product Split because the image extends to the edge of the screen. In Banner, there's a fixed margin-left that is not suitable for a hero pattern. I assume the similarity comes from the 64 px top and bottom margins I added in Figma (the equivalent of block spacing in Global Styles). |
@jarekmorawski thanks:
The reason I flagged it is that on the Figma design, the text doesn't match what we currently have for the Hero Product Split pattern; it matches what is displayed for the Banner Pattern instead (with the only exception being the button text - see screenshots shared in previous comment over here).
Considering Hero Product Split pattern is the one we aim to wireframe, should the text of this pattern be updated as well so it matches the design on Figma? |
No, I'll update the Figma. Thanks for bringing this up! Let's use the copy we already have. |
Excellent, thanks for confirming! 🙌 |
As decided on #10086 (comment), we need to remove all opinionated styles from the Hero Product Split Pattern, including custom font colors, background, button colors, and any other additional styles (if found).
Screenshot
Designs
Figma: F5AAbRJOGbTeEweXPFtHgf-fi-2242_36072
The text was updated successfully, but these errors were encountered: