Fix: Empty Mini Cart Contents view in editor is not vertically center…

…ed on WP 6.0 (#6379)
woocommerce · May 6, 2022 · 9dd3ac8 · 9dd3ac8
1 parent 8b9bad7
commit 9dd3ac8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/assets/js/blocks/mini-cart/mini-cart-contents/editor.scss b/assets/js/blocks/mini-cart/mini-cart-contents/editor.scss
@@ -55,19 +55,21 @@
 	}
 
 	.wp-block-woocommerce-empty-mini-cart-contents-block {
+		min-height: 100vh;
 		overflow-y: unset;
 		padding: 0;
 
 		> .block-editor-inner-blocks {
+			box-sizing: border-box;
 			max-height: 100vh;
 			overflow-y: auto;
-			box-sizing: border-box;
 			padding: $gap-largest $gap $gap;
 		}
 
 		// Temporary fix after the appender button was positioned absolute
 		// See https://github.com/woocommerce/woocommerce-gutenberg-products-block/issues/5742#issuecomment-1032804168
 		.block-list-appender {
+			margin-top: $gap;
 			position: relative;
 		}
 

diff --git a/...cks/mini-cart/mini-cart-contents/inner-blocks/empty-mini-cart-contents-block/frontend.tsx b/...cks/mini-cart/mini-cart-contents/inner-blocks/empty-mini-cart-contents-block/frontend.tsx
@@ -33,7 +33,9 @@ const EmptyMiniCartContentsBlock = ( {
 
 	return (
 		<div tabIndex={ -1 } ref={ elementRef } className={ className }>
-			{ children }
+			<div className="wc-block-mini-cart__empty-cart-wrapper">
+				{ children }
+			</div>
 		</div>
 	);
 };

diff --git a/assets/js/blocks/mini-cart/style.scss b/assets/js/blocks/mini-cart/style.scss
@@ -84,7 +84,7 @@
 	justify-content: space-between;
 }
 
-.wp-block-woocommerce-empty-mini-cart-contents-block {
+.wp-block-woocommerce-empty-mini-cart-contents-block .wc-block-mini-cart__empty-cart-wrapper {
 	overflow-y: auto;
 	padding: $gap-largest $gap $gap;
 }