Avoid extra is-loading classname

woocommerce · May 27, 2021 · 6378390 · 6378390
1 parent c70b599
commit 6378390
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/assets/js/base/components/loading-mask/index.js b/assets/js/base/components/loading-mask/index.js
@@ -20,17 +20,15 @@ const LoadingMask = ( {
 } ) => {
 	return (
 		<div
-			className={ classNames(
-				className,
-				'wc-block-components-loading-mask',
-				{
-					'is-loading': isLoading,
-				}
-			) }
+			className={ classNames( className, {
+				'wc-block-components-loading-mask': isLoading,
+			} ) }
 		>
 			{ isLoading && showSpinner && <Spinner /> }
 			<div
-				className="wc-block-components-loading-mask__children"
+				className={ classNames( {
+					'wc-block-components-loading-mask__children': isLoading,
+				} ) }
 				aria-hidden={ isLoading }
 			>
 				{ children }

diff --git a/assets/js/base/components/loading-mask/style.scss b/assets/js/base/components/loading-mask/style.scss
@@ -1,4 +1,4 @@
-.wc-block-components-loading-mask.is-loading {
+.wc-block-components-loading-mask {
 	position: relative;
 	min-height: 18px + $gap;
 	pointer-events: none;