Flush after updating all products, not after updating each of the pro…

…ducts Flushing is an expensive operation so we should run it carefully
woocommerce · Nov 28, 2023 · 53d3d9c · 53d3d9c
1 parent fd7efc7
commit 53d3d9c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/src/Patterns/ProductUpdater.php b/src/Patterns/ProductUpdater.php
@@ -260,7 +260,6 @@ public function update_product_content( $ai_generated_product_content ) {
 				),
 			)
 		);
-		flush_rewrite_rules();
 
 		require_once ABSPATH . 'wp-admin/includes/media.php';
 		require_once ABSPATH . 'wp-admin/includes/file.php';

diff --git a/src/StoreApi/Routes/V1/AI/Product.php b/src/StoreApi/Routes/V1/AI/Product.php
@@ -81,6 +81,7 @@ protected function get_route_post_response( \WP_REST_Request $request ) {
 		}
 
 		$product_updater->update_product_content( $product_information );
+		flush_rewrite_rules();
 
 		return rest_ensure_response(
 			array(
-Original file line number
+Diff line change
@@ Expand Up @@
     				),
     			)
     		);
-    		flush_rewrite_rules();
     		require_once ABSPATH . 'wp-admin/includes/media.php';
     		require_once ABSPATH . 'wp-admin/includes/file.php';
@@ Expand Down @@