This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adds product query support for Category list block (#7675)
* Adds product query support for Category list block On the client side, when the Category list block is used within the product query bloc, the markup will be rendered on the server side - No javascript related to Category list block will be rendered. * bot: update checkstyle.xml * Fix extra space after the category link I used the solution from following link: https://css-tricks.com/fighting-the-space-between-inline-block-elements/#aa-remove-the-spaces Here is the content from the above link: The reason you get the spaces is because, well, you have spaces between the elements (a line break and a few tabs counts as a space, just to be clear). Minimized HTML will solve this problem, or one of these tricks: ```CSS <ul> <li> one</li><li> two</li><li> three</li> </ul> ``` or ```CSS <ul> <li>one</li ><li>two</li ><li>three</li> </ul> ``` or with comments… ```CSS <ul> <li>one</li><!-- --><li>two</li><!-- --><li>three</li> </ul> ``` They’re all pretty funky, but it does the trick. * Fix custom style doesn't work on the frontend side For more info, check this comment on the PR: #7675 (review) In summary, user can set the custom styles like text color, link color, font size, font weight, line height using the editor sidebar. These styles weren't showing on the frontend side. * Add support for additional CSS class(es) * Fix "custom style -> link color" not working To understand the issue in more details please check following comment: #7675 (comment) * Fix classname undefined issue Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
- Loading branch information
1 parent
6171117
commit 222c977
Showing
7 changed files
with
88 additions
and
46 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 0 additions & 21 deletions
21
assets/js/atomic/blocks/product-elements/category-list/save.tsx
This file was deleted.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
assets/js/atomic/blocks/product-elements/category-list/types.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
export interface Attributes { | ||
productId: number; | ||
isDescendentOfQueryLoop: boolean; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters