Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/13127 add edit sites button #13135

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

JorgeMucientes
Copy link
Contributor

Closes: #13127

Description

Adds new Edit Stores button to site picker when the list displays more than 1 site. Additionally, adds a feature flag to avoid showing this new button in production builds.

No unit tests for now, as the feature is WIP and the logic is super simple at this point.

Testing information

  1. Log into the app using WP.com credentials with an account that has multiple stores
  2. Go to site picker
  3. Check the new button Edit Stores is displayed once the store list is loaded

The tests that have been performed

The above

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@JorgeMucientes JorgeMucientes added unit-tests-exemption feature: site picker Any task related to site picker screen labels Dec 13, 2024
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit9eeb1e2
Direct Downloadwoocommerce-wear-prototype-build-pr13135-9eeb1e2.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit9eeb1e2
Direct Downloadwoocommerce-prototype-build-pr13135-9eeb1e2.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: site picker Any task related to site picker screen unit-tests-exemption
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Edit button to site picker when there are more than 1 site listed
3 participants