Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bulk Update Orders] Enable multiple selection in Order List #13131

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

hafizrahman
Copy link
Contributor

@hafizrahman hafizrahman commented Dec 13, 2024

Part of: #13130

Description

This PR starts the implementation for SelectionTracker in OrderListFragment, to start enabling multi-selection behavior on it.

The entry point for the change here is addSelectionTracker() in OrderListFragment. For the most part, its implementation follows closely the existing addSelectionTracker() in ProductListFragment as it's enabling the same feature. It might be good to compare this PR with the implementation there when reviewing.

Documentation: https://developer.android.com/reference/androidx/recyclerview/selection/package-summary

Steps to reproduce

Testing information

The tests that have been performed

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@dangermattic
Copy link
Collaborator

5 Errors
🚫 Please add tests for class OrderSelectionItemKeyProvider (or add unit-tests-exemption label to ignore this).
🚫 Please add tests for class SelectableOrderListItemLookup (or add unit-tests-exemption label to ignore this).
🚫 Please add tests for class DefaultOrderListItemLookup (or add unit-tests-exemption label to ignore this).
🚫 Please add tests for class DefaultOrderItemDetailsLookup (or add unit-tests-exemption label to ignore this).
🚫 Please add tests for class SelectableOrderItemDetailsLookup (or add unit-tests-exemption label to ignore this).
1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit8f304b5
Direct Downloadwoocommerce-wear-prototype-build-pr13131-8f304b5.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit8f304b5
Direct Downloadwoocommerce-prototype-build-pr13131-8f304b5.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants