Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS][Cash & Receipts] Implement receipts UI #13123

Open
wants to merge 19 commits into
base: 13106-woo-poscash-receipts-implement-navigation-via-nav-component-to-the-full-receipts-sending-screen
Choose a base branch
from

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Dec 12, 2024

Closes: #13117

Description

The PR implements the UI of the email receipts screen. There is no success confirmation yet, as this is under consideration yet

Testing information

  • POS -> Successful payment -> Email receipt
  • Notice and validate the UI and it's behavior

rNAclWFAdQRw7EXEcsNVai-fi-2949_5786

The tests that have been performed

Above

Images/gif

12-13--11-03.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@dangermattic
Copy link
Collaborator

dangermattic commented Dec 12, 2024

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@kidinov kidinov changed the base branch from 13092-woo-poscash-receipts-ui-loading-error-state-of-the-cash-payment-screen to 13106-woo-poscash-receipts-implement-navigation-via-nav-component-to-the-full-receipts-sending-screen December 12, 2024 16:11
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 12, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitf089bd9
Direct Downloadwoocommerce-wear-prototype-build-pr13123-f089bd9.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 12, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitf089bd9
Direct Downloadwoocommerce-prototype-build-pr13123-f089bd9.apk

keyboardOptions: KeyboardOptions = KeyboardOptions.Default,
keyboardActions: KeyboardActions = KeyboardActions.Default,
contentAlignment: Alignment = Alignment.CenterStart,
modifier: Modifier = Modifier,

Check warning

Code scanning / Android Lint

Guidelines for Modifier parameters in a Composable function Warning

Modifier parameter should be the first optional parameter
@kidinov kidinov requested a review from samiuelson December 13, 2024 10:24
@kidinov kidinov added the feature: point of sale POS project label Dec 13, 2024
@kidinov kidinov added this to the 21.3 milestone Dec 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 32.00000% with 102 lines in your changes missing coverage. Please review.

Project coverage is 40.44%. Comparing base (4d520a8) to head (f089bd9).

Files with missing lines Patch % Lines
...os/common/composeui/component/WooPosInputFields.kt 0.00% 59 Missing ⚠️
...woopos/common/composeui/component/WooPosToolbar.kt 0.00% 34 Missing ⚠️
...oopos/emailreceipt/WooPosEmailReceiptRepository.kt 50.00% 2 Missing ⚠️
.../ui/woopos/emailreceipt/WooPosEmailReceiptState.kt 86.66% 2 Missing ⚠️
...woopos/emailreceipt/WooPosEmailReceiptViewModel.kt 94.28% 0 Missing and 2 partials ⚠️
...woopos/common/composeui/component/WooPosButtons.kt 0.00% 1 Missing ⚠️
...ui/woopos/root/navigation/WooPosNavigationEvent.kt 0.00% 1 Missing ⚠️
...os/root/navigation/WooPosNavigationEventHandler.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                                             Coverage Diff                                                             @@
##             13106-woo-poscash-receipts-implement-navigation-via-nav-component-to-the-full-receipts-sending-screen   #13123      +/-   ##
===========================================================================================================================================
+ Coverage                                                                                                    40.43%   40.44%   +0.01%     
- Complexity                                                                                                    6215     6223       +8     
===========================================================================================================================================
  Files                                                                                                         1299     1300       +1     
  Lines                                                                                                        74845    74976     +131     
  Branches                                                                                                     10249    10275      +26     
===========================================================================================================================================
+ Hits                                                                                                         30264    30326      +62     
- Misses                                                                                                       41955    42022      +67     
- Partials                                                                                                      2626     2628       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants