-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shipping Labels Revamp] Handle Package selection on the main form #13111
Conversation
…also trigger back navigation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…dling with Shipping Rates
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13111 +/- ##
============================================
+ Coverage 40.34% 40.36% +0.02%
- Complexity 6204 6206 +2
============================================
Files 1296 1296
Lines 74932 74961 +29
Branches 10272 10275 +3
============================================
+ Hits 30233 30261 +28
- Misses 42061 42062 +1
Partials 2638 2638 ☔ View full report in Codecov by Sentry. |
onClick = onSelectPackageClick | ||
) { | ||
Icon( | ||
painter = painterResource(id = R.drawable.ic_edit), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np: We should use the material pencil here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's true! Thanks for the suggestion, it's fixed in 5aff9b3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Nice work @ThomazFB! Everything is working as described. I left a small observation about the pencil icon, but is not a blocker for this PR
Summary
Fix issue #12747 by introducing the complete handling of the Package selection into the main Shipping Labels form.
Screen Capture
Screen_recording_20241212_184222.mp4
How to Test
Scenario 1 - Carrier Package
Select a Package
buttonAdd Package
ButtonScenario 2 - Saved Package
Select a Package
buttonAdd Package
ButtonScenario 3 - Custom Package not saved as a template
Select a Package
buttonsave as template
check and hit theAdd Package
ButtonCustom Package
Scenario 4 - Custom Package saved as a template
Select a Package
buttonsave as template
checkAdd Package
ButtonUpdate release notes:
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: