-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI Test] Test for "login not WP" case. #13098
base: trunk
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…se on a non wp site.
…t response on a non wp site." This reverts commit ef8b3bd.
…ent response on a non wp site.
"urlPath": "/rest/v1.1/connect/site-info/", | ||
"queryParameters": { | ||
"url": { | ||
"matches": ".*notawpsite.com.*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remark, the .
in the site address there matches any character, you might want to replace it with \\.
import com.woocommerce.android.R | ||
import com.woocommerce.android.e2e.helpers.util.Screen | ||
|
||
class LoginNotWPScreen : Screen { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark, technically, the error is shown on the SiteAddressScreen,
saying LoginNotWPScreen
could be confusing in the future; I suggest putting the logic of this class in the same SiteAddressScreen
class, and updating the openLoginNotWpScreen
with something like enterNonWPAddress
, WDYT?
Closes: #13097
Description
Steps to reproduce
Testing information
The tests that have been performed
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: