Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Test] Test for "login not WP" case. #13098

Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Draft

Conversation

hafizrahman
Copy link
Contributor

Closes: #13097

Description

Steps to reproduce

Testing information

The tests that have been performed

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 10, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit2b6c9a1
Direct Downloadwoocommerce-wear-prototype-build-pr13098-2b6c9a1.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 10, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit2b6c9a1
Direct Downloadwoocommerce-prototype-build-pr13098-2b6c9a1.apk

"urlPath": "/rest/v1.1/connect/site-info/",
"queryParameters": {
"url": {
"matches": ".*notawpsite.com.*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remark, the . in the site address there matches any character, you might want to replace it with \\.

import com.woocommerce.android.R
import com.woocommerce.android.e2e.helpers.util.Screen

class LoginNotWPScreen : Screen {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark, technically, the error is shown on the SiteAddressScreen, saying LoginNotWPScreen could be confusing in the future; I suggest putting the logic of this class in the same SiteAddressScreen class, and updating the openLoginNotWpScreen with something like enterNonWPAddress, WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not a WP site
4 participants