-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POS][Custom payment UI] – Reader not connected error handling #13053
[POS][Custom payment UI] – Reader not connected error handling #13053
Conversation
given reader not connected, when VM checkout clicked, then should show error
given order draft created, when reader connects, then start payment automatically
1. given order draft created, when reader connects, then start payment automatically 2. given order draft created, when reader disconnects, then should abort payment action
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## custom-payment-ui-7-payment-cancelation #13053 +/- ##
=============================================================================
+ Coverage 40.20% 40.23% +0.02%
- Complexity 6064 6073 +9
=============================================================================
Files 1272 1272
Lines 73782 73829 +47
Branches 10089 10094 +5
=============================================================================
+ Hits 29666 29706 +40
- Misses 41541 41548 +7
Partials 2575 2575 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @samiuelson. Looks and tests well. I have just left one non-blocking comment.
@@ -186,6 +190,8 @@ private val DarkCustomColors = CustomColors( | |||
border = WooPosColors.oldGrayMedium, | |||
success = WooPosColors.greenNotFromPalette, | |||
error = WooPosColors.darkCustomColorsError, | |||
totalsErrorBackground = WooPosColors.darkQuaternaryBackground, | |||
totalsBackground = Color(0xFF1C1C1E), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Do we want to give this color a symantic name and use that name here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed – ca31607
4c58cf9
into
custom-payment-ui-6-use-payment-controller-in-pos
Closes: #13005
Description
This PR:
Design specs: TfaZ4LUkEwEGrxfnEFzvJj-fi-2530_13218
trunk
.Steps to reproduce
Testing information
The tests that have been performed
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: