-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dark mode issues #12966
Fix dark mode issues #12966
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12966 +/- ##
============================================
- Coverage 39.73% 39.73% -0.01%
Complexity 5983 5983
============================================
Files 1267 1267
Lines 73223 73224 +1
Branches 10041 10042 +1
============================================
Hits 29094 29094
- Misses 41563 41564 +1
Partials 2566 2566 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Part of: #12281
Description
This PR fixes two small issues in dark mode.
The first one is the purchase button elevation. In dark mode, the bottom section elevation differs from the bottom sheet, making the UI look weird. In this PR, I fix that by using different elevations depending on whether the device is in dark mode or expanded.
The second issue was the selected rate background in dark mode.
Testing information
The tests that have been performed
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: