[POS] Custom payment UI — Part 5 | Unit tests clean up #12943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiuelson
added
the
status: do not merge
`given collect payment shown, when RETRY message received, then collect payment hint updated`
samiuelson
force-pushed
the
custom-payment-ui-5
branch
from
77a1b42 to
8676fe1
Compare
`given collect payment shown, when INSERT_CARD received, then collect payment hint updated`
`given collect payment shown, when SWIPE_CARD received, then collect payment hint updated`
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
`given collect payment shown, when REMOVE_CARD received, then collect payment hint updated`
`given collect payment shown, when TRY_OTHER_CARD message received, then collect payment hint updated`
`given collect payment shown, when CARD_REMOVED_TOO_EARLY message received, then collect payment hint updated`
`given collect payment shown, when TRY_OTHER_READ message received, then collect payment hint updated`
`given collect payment shown, when MULTIPLE_CARDS_DETECTED received, then collect payment hint updated`
`given fetching order fails, when payment screen shown, then ExternalReaderFailedPayment state is shown`
`given fetching order fails and tpp, when payment screen shown, then BuiltInReaderFailedPayment state is shown`
`when fetching order fails, then event tracked`
`given fetching order succeeds, when payment screen shown, then order currency stored `
`when payment screen shown, then loading data state is emitted`
`when payment not collectable, then error event emitted and flow terminated`
`when flow started, then correct payment description is propagated to CardReaderManager`
`when flow started, then correct statement descriptor is propagated to CardReaderManager`
`when initializing payment, then Loading state emitted`
`when collecting payment, then CollectingPayment state emitted`
`given built in reader,when collecting payment, then ui CollectingPayment state emitted`
`when processing payment, then ProcessingPayment state emitted`
`given built in reader, when processing payment, then ProcessingPayment state emitted`
`when processing payment completed with card present, then tracking keeper stores payment type`
samiuelson
changed the title
This was referenced Nov 18, 2024
`given billing email empty and built in, when user clicks on print receipt button, then event tracked`
`given billing email not empty and external, when user clicks on print receipt button, then event tracked`
`given billing email not empty and built in, when user clicks on print receipt button, then event tracked`
`given get receipt url fails, when user clicks on print receipt button, then error event emitted`
`given get receipt url succeeds, when user clicks on print receipt button, then PrintReceipt emitted`
`when OS accepts the print request, then print success event tracked` `when OS refuses the print request, then print failed event tracked` `when manually cancels the print request, then print cancelled event tracked`
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| xmlns:tools="http://schemas.android.com/tools" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| xmlns:app="http://schemas.android.com/apk/res-auto" | ||
| android:background="?attr/colorSurface" |
Check warning
Code scanning / Android Lint
Overdraw: Painting regions more than once Warning
| @@ -4372,4 +4381,5 @@ | |||
| <string name="woo_shipping_labels_package_creation_add_package">Add Package</string> | |||
| <string name="woo_shipping_labels_package_creation_box_type">Box</string> | |||
| <string name="woo_shipping_labels_package_creation_envelope_type">Envelope</string> | |||
| <string name="email_not_registered_wpcom">Hmm, we can\'t find a WordPress.com account connected to this email address.</string> | |||
Check warning
Code scanning / Android Lint
Unused resources Warning
Base automatically changed from
custom-payment-ui-4
to
feature/custom-payment-ui
November 25, 2024 13:13
`given collect payment NOT shown, when show additional info event received, then event ignored`
samiuelson
removed
the
status: do not merge
samiuelson
added
the
feature: mobile payments
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12943
Description
The intent of This PR is to clean up unit tests of
CardReaderPaymentControllerTestandCardReaderPaymentViewModelTest.This is part 5 of 5 PRs refactoring the Payment flow:
💡 This PR intends to merge changes to the
feature/custom-payment-uifeature branch, that will be additionally tested and merged totrunklater.Testing information
This PR is quite big, however, it modifies only two files:
CardReaderPaymentControllerTestandCardReaderPaymentViewModelTest. It also does not introduce any new tests, only moves test methods around so that they are closer to the class they are testing.ViewStatetestsI copied all the unit test methods verifying
CardReaderPaymentViewModel.viewStateDatatoCardReaderPaymentControllerTestand adapted them to testCardReaderPaymentController.paymentStateinstead. I left original tests as well because they are testing theCardReaderPaymentStateToViewStateMapperas a black box.ViewStatewere moved toCardReaderPaymentControllerTest(and removed fromCardReaderPaymentViewModelTest)The tests that have been performed
I verified that
CardReaderPaymentViewModelTestdoes not contain test methods that are more suitable for the controller.Testing
I recommend checking this PR as a whole
CardReaderPaymentViewModelTestand look if there is a class that could be moved or copied/adapted to theCardReaderPaymentControllerclass.Images/gif
—
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: