Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS - payments onboarding] Remove local FF #12942

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Nov 18, 2024

Closes: #12928

Description

The PR removes feature flag

Testing information

  • Use both release and debug builds
  • Use site with unfinished onboarding
  • More -> Payments
  • Notice that POS is available for both builds
  • Notice that onboarding is shown on the both builds

The tests that have been performed

Above

Images/gif

11-18--16-35.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@dangermattic
Copy link
Collaborator

dangermattic commented Nov 18, 2024

1 Warning
⚠️ This PR is assigned to the milestone 21.2. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 18, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit503f98d
Direct Downloadwoocommerce-wear-prototype-build-pr12942-503f98d.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 18, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit503f98d
Direct Downloadwoocommerce-prototype-build-pr12942-503f98d.apk

@kidinov kidinov changed the title [Woo POS - payments onboarding remove local FF] [Woo POS - payments onboarding] Remove local FF Nov 18, 2024
@kidinov kidinov added the feature: point of sale POS project label Nov 18, 2024
@kidinov kidinov added this to the 21.2 milestone Nov 18, 2024
@kidinov kidinov added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Nov 18, 2024
@kidinov kidinov requested a review from AnirudhBhat November 18, 2024 15:41
@AnirudhBhat AnirudhBhat self-assigned this Nov 19, 2024
Copy link
Contributor

@AnirudhBhat AnirudhBhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @kidinov. LGTM :shipit: I'll merge this after I review the base PR.

Base automatically changed from 12903-woo-pos---payments-onboarding-add-analytics-events to trunk November 19, 2024 14:16
@kidinov kidinov linked an issue Nov 19, 2024 that may be closed by this pull request
@kidinov kidinov removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Nov 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.73%. Comparing base (81b12c9) to head (503f98d).
Report is 12 commits behind head on trunk.

Files with missing lines Patch % Lines
...m/woocommerce/android/ui/woopos/WooPosIsEnabled.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #12942      +/-   ##
============================================
- Coverage     39.73%   39.73%   -0.01%     
+ Complexity     5985     5983       -2     
============================================
  Files          1268     1267       -1     
  Lines         73252    73222      -30     
  Branches      10061    10041      -20     
============================================
- Hits          29106    29094      -12     
+ Misses        41564    41562       -2     
+ Partials       2582     2566      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@kidinov kidinov merged commit 7ea476b into trunk Nov 21, 2024
16 checks passed
@kidinov kidinov deleted the 12928-woo-pos---payments-onboarding-remove-local-ff branch November 21, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS - payments onboarding] Remove Local FF
5 participants