[Woo POS][Non-Simple Products] Add variation to cart #12926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…45-add-variation-to-cart # Conflicts: # WooCommerce/src/test/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsViewModelTest.kt
AnirudhBhat
added
type: task
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12926 +/- ##
============================================
+ Coverage 39.59% 39.61% +0.02%
- Complexity 5956 5965 +9
============================================
Files 1267 1268 +1
Lines 73179 73214 +35
Branches 10048 10052 +4
============================================
+ Hits 28976 29006 +30
- Misses 41629 41633 +4
- Partials 2574 2575 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…45-add-variation-to-cart # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/variations/WooPosVariationsViewModel.kt # WooCommerce/src/test/kotlin/com/woocommerce/android/ui/woopos/home/variations/WooPosVariationsViewModelTest.kt
…45-add-variation-to-cart # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItem.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsViewModel.kt # WooCommerce/src/test/kotlin/com/woocommerce/android/ui/woopos/home/items/LeftPaneNavigatorTest.kt # WooCommerce/src/test/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsViewModelTest.kt
…45-add-variation-to-cart
…45-add-variation-to-cart # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/variations/WooPosVariationsScreen.kt
…45-add-variation-to-cart # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/variations/WooPosVariationsViewModel.kt # WooCommerce/src/test/kotlin/com/woocommerce/android/ui/products/ProductTestUtils.kt
…45-add-variation-to-cart
|
Version |
samiuelson
approved these changes
Nov 22, 2024
| is ParentToChildrenEvent.BackFromCheckoutToCartClicked -> handleBackFromCheckoutToCartClicked() | ||
| is ParentToChildrenEvent.ItemClickedInProductSelector -> handleItemClickedInProductSelector(event) | ||
| is ParentToChildrenEvent.OrderSuccessfullyPaid -> handleOrderSuccessfullyPaid() | ||
| is ParentToChildrenEvent.CheckoutClicked -> handleCheckoutClicked() |
There was a problem hiding this comment.
💡 np.: It's a bit confusing to redirect to an empty function (handleCheckoutClicked()). How about this?
Suggested change
| is ParentToChildrenEvent.CheckoutClicked -> handleCheckoutClicked() | |
| is ParentToChildrenEvent.CheckoutClicked -> Unit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12845
Description
This PR adds variation to the cart when clicked from the variations list screen.
Testing information
Try adding different variations of a variable product to the cart and ensure they all get added to the cart with correct name and variation attribute.
The tests that have been performed
Adding different variations to the cart in both dark and light mode.
Images/gif
add_variation_to_cart_demo.mp4
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: