-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS payments onboarding] Analytics events #12922
[Woo POS payments onboarding] Analytics events #12922
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12922 +/- ##
============================================
+ Coverage 39.61% 39.64% +0.02%
- Complexity 5925 5935 +10
============================================
Files 1261 1261
Lines 72843 72867 +24
Branches 9963 9967 +4
============================================
+ Hits 28855 28885 +30
+ Misses 41415 41408 -7
- Partials 2573 2574 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…-dont-know-country-and-currency' into 12903-woo-pos---payments-onboarding-add-analytics-events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @kidinov. Overall, it looks good. I noticed that woocommerceandroid_card_present_onboarding_not_completed
event gets triggered twice. First when the onboarding error screen is shown in POS and the second time when you exit the POS Mode.
@AnirudhBhat thanks for the review Yep, that's kinda expected as we track the status every time we check it |
Closes: #12903
Description
The PR adds:
Tracking events
Steps to reproduce
Notice the events:
Testing information
Follow steps to reproduce
The tests that have been performed
From steps to reproduce
Images/gif
No UI changes in the PR expected
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: