[Woo POS][Non Simple product types] Fetch variations list #12910

AnirudhBhat · 2024-11-12T11:07:45Z

Closes: #12844

NOTE: I've extracted the UI in the products screen into separate file which is the cause for many line changes.

Description

This PR fetches variations list and displays on the variations screen.

It makes use of existing VariationsListHandler class for fetching variations.

Testing information

Testing Variations list

Navigate to POS mode (more menu -> POS)
Click on any variable product
Ensure you see variations displayed

Testing Variations pagination

Navigate to POS mode (more menu -> POS)
Click on any variable product that has more than 10 variations
Ensure you see variations displayed and it paginates as expected

Testing Variations pagination error

Navigate to POS mode (more menu -> POS)
Click on any variable product that has more than 10 variations
Ensure you see variations displayed
Turn on airplane mode
Scroll down to end of the list
Ensure you see snackbar message that says failed to fetch variations.

Testing Variations fetch error

Navigate to POS mode (more menu -> POS)
Turn on airplane mode
Click on any variable product
Ensure you see appropriate error screen

The tests that have been performed

Tested all the above scenario listed in both light and dark modes on emulator.

Images/gif

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

…iewState

…or all items list screens like products, variations ...etc

…ew model is initiated.

…ns view model is initiated.

…iations view model is initiated.

…ceRefresh set to true when variations view model is initiated.

…call is successful.

…properties when the API call is successful.

…g property set to true when pull to refreshed

…property set to true when pull to refreshed

…ched.

…st.kt

wpmobilebot · 2024-11-12T11:45:33Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`4e26906`
	Direct Download	`woocommerce-prototype-build-pr12910-4e26906.apk`

…nto issue/12844-fetch-variations # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsScreen.kt # WooCommerce/src/main/res/values/strings.xml

codecov-commenter · 2024-11-15T04:00:52Z

Codecov Report

Attention: Patch coverage is 32.02417% with 225 lines in your changes missing coverage. Please review.

Project coverage is 39.59%. Comparing base (fb44b49) to head (4e26906).
Report is 210 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...ce/android/ui/woopos/home/items/WooPosItemsList.kt	0.00%	183 Missing ⚠️
...ome/items/variations/WooPosVariationsDataSource.kt	4.16%	23 Missing ⚠️
...home/items/variations/WooPosVariationsViewModel.kt	85.13%	3 Missing and 8 partials ⚠️
...droid/ui/woopos/home/items/WooPosItemsViewModel.kt	0.00%	4 Missing ⚠️
.../ui/woopos/home/items/WooPosVariationsViewState.kt	83.33%	3 Missing ⚠️
...oducts/variations/selector/VariationListHandler.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #12910      +/-   ##
============================================
- Coverage     39.63%   39.59%   -0.04%     
- Complexity     5932     5956      +24     
============================================
  Files          1261     1267       +6     
  Lines         72862    73179     +317     
  Branches       9965    10048      +83     
============================================
+ Hits          28879    28976      +97     
- Misses        41414    41629     +215     
- Partials       2569     2574       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

…variation items in the items list

AnirudhBhat · 2024-11-18T04:06:21Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsList.kt

@@ -0,0 +1,343 @@
+package com.woocommerce.android.ui.woopos.home.items
+
+import androidx.compose.foundation.ExperimentalFoundationApi


Most of this changes are because of extracting it into different file.

AnirudhBhat · 2024-11-18T04:08:01Z

...ain/kotlin/com/woocommerce/android/ui/woopos/home/items/variations/WooPosVariationsScreen.kt

+            .collect { event ->
+                when (event) {
+                    is WooPosVariationsViewModel.WooPosVariationEvents.PaginationError -> {
+                        snackbarHostState.showSnackbar(


We may change from showing snack bar into a card with retry button. If we decide on that, I will raise a separate PR for it.

…nto issue/12844-fetch-variations

…nto issue/12844-fetch-variations # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItem.kt # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/variations/WooPosVariationsScreen.kt # WooCommerce/src/main/res/values/strings.xml

…nto issue/12844-fetch-variations # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsScreen.kt

… price is set to 0

samiuelson

LGTM!

samiuelson · 2024-11-20T11:44:46Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsList.kt

+
+@OptIn(ExperimentalFoundationApi::class)
+@Composable
+fun ItemsList(


💡 n.p. In store management we follow the convention of singular+List (e.g. itemList) or just plural (with "s", without "List"). Maybe it's worth renaming?

Done: 4e26906

AnirudhBhat added 30 commits November 11, 2024 10:33

Add WooPosBaseViewState that acts as a parent for all items view state

c3ef48f

Refactor WooPosItemsViewState to incorporate changes from WooPosBaseV…

ef718d0

…iewState

Add WooPosVariationsViewState

3835590

Add Variation model

18d1fcb

Extract ItemsList UI into a separate class so that it can be reused f…

3b19d37

…or all items list screens like products, variations ...etc

Extract ItemsList UI into a separate class so that it can be reused f…

35b91c8

…or all items list screens like products, variations ...etc

Add a dummy click handler for variations.

1d855cd

Add variations screen and view model

b382757

Add a data source as a middle layer for fetching variations

252027f

Add UI events model for variations screen

db3ad05

Use the variations source middle layer in the view model

7ee2e57

Integrate pull to refresh into the variations screen.

d1abab9

Uncomment preview code

4456ba1

Add unit test to verify loading state is displayed when variations vi…

77d714e

…ew model is initiated.

Add unit test to verify loading state is displayed when variations vi…

12afd8a

…ew model is initiated.

Add unit test to verify API call is made to get product when variatio…

8875cee

…ns view model is initiated.

Add unit test to verify API call is made to fetch variations when var…

58c0b6f

…iations view model is initiated.

Add unit test to verify API call is made to fetch variations with for…

e2a5e99

…ceRefresh set to true when variations view model is initiated.

Add unit test to verify that content state is displayed when the API …

05e1f44

…call is successful.

Add unit test to verify that content state is displayed with correct …

fa9577b

…properties when the API call is successful.

Add unit test to verify that content state is displayed with correct …

19239ad

…properties when the API call is successful.

Add unit test to verify that content state is displayed with reloadin…

820e0fa

…g property set to true when pull to refreshed

Add unit test to verify that Loading state is displayed with reloadin…

b18a888

…g property set to true when pull to refreshed

Return result from fetchVariations method

925ee86

Add unit test to verify that Error state is displayed with reloading …

109f7b9

…property set to true when pull to refreshed

Make all the tests pass

a57f858

Add test to verify error state is displayed when load more call fails

8b5f632

Add test to verify error state is displayed when load more call fails

d684761

Add test to verify load more method is called when end of list is rea…

80597cc

…ched.

Extract ItemsLoadingIndicator from WooPosItemsScreen to WooPosItemsLi…

502789b

…st.kt

AnirudhBhat added 2 commits November 12, 2024 16:52

Handle retry logic for variations

773a41b

Add test to verify retry button click would call fetchVariations

ef20d8e

AnirudhBhat added the unit-tests-exemption label Nov 12, 2024

Merge branch 'refs/heads/issue/12843-navigate-to-variations-screen' i…

6bb152e

…nto issue/12844-fetch-variations # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsScreen.kt # WooCommerce/src/main/res/values/strings.xml

AnirudhBhat added 5 commits November 18, 2024 09:29

Add string resource for content description for Variable product and …

d966696

…variation items in the items list

Display price for variation in the items list screen

b0a13ec

Format price before displaying for variations

f3e6504

Fix failing tests

1e03af7

Remove unused imports

39d094b

AnirudhBhat requested a review from samiuelson November 18, 2024 04:10

AnirudhBhat marked this pull request as ready for review November 18, 2024 04:11

AnirudhBhat commented Nov 18, 2024

View reviewed changes

AnirudhBhat added 2 commits November 18, 2024 11:26

Merge branch 'refs/heads/issue/12843-navigate-to-variations-screen' i…

3fed048

…nto issue/12844-fetch-variations

samiuelson self-assigned this Nov 19, 2024

AnirudhBhat added 5 commits November 20, 2024 09:48

Merge branch 'refs/heads/issue/12843-navigate-to-variations-screen' i…

c3b087c

…nto issue/12844-fetch-variations # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsScreen.kt

Fix merge conflicts

290637f

Remove unused import

786f703

pass list state from variations screen

363647e

filter out variations with price set to null and allow products whose…

14d9e4c

… price is set to 0

Base automatically changed from issue/12843-navigate-to-variations-screen to trunk November 20, 2024 08:53

Make the tests pass

d744399

samiuelson approved these changes Nov 20, 2024

View reviewed changes

AnirudhBhat added this to the 21.2 milestone Nov 21, 2024

Change the name from ItemsList to ItemList

4e26906

AnirudhBhat enabled auto-merge November 21, 2024 04:31

AnirudhBhat merged commit 81b12c9 into trunk Nov 21, 2024
15 checks passed

AnirudhBhat deleted the issue/12844-fetch-variations branch November 21, 2024 04:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Woo POS][Non Simple product types] Fetch variations list #12910

[Woo POS][Non Simple product types] Fetch variations list #12910

AnirudhBhat commented Nov 12, 2024 •

edited

Loading

wpmobilebot commented Nov 12, 2024 •

edited

Loading

codecov-commenter commented Nov 15, 2024 •

edited

Loading

AnirudhBhat Nov 18, 2024

AnirudhBhat Nov 18, 2024

samiuelson left a comment

samiuelson Nov 20, 2024

AnirudhBhat Nov 21, 2024

		@@ -0,0 +1,343 @@
		package com.woocommerce.android.ui.woopos.home.items

		import androidx.compose.foundation.ExperimentalFoundationApi

[Woo POS][Non Simple product types] Fetch variations list #12910

[Woo POS][Non Simple product types] Fetch variations list #12910

Conversation

AnirudhBhat commented Nov 12, 2024 • edited Loading

NOTE: I've extracted the UI in the products screen into separate file which is the cause for many line changes.

Description

Testing information

The tests that have been performed

Images/gif

Reviewer (or Author, in the case of optional code reviews):

wpmobilebot commented Nov 12, 2024 • edited Loading

codecov-commenter commented Nov 15, 2024 • edited Loading

Codecov Report

AnirudhBhat Nov 18, 2024

Choose a reason for hiding this comment

AnirudhBhat Nov 18, 2024

Choose a reason for hiding this comment

samiuelson left a comment

Choose a reason for hiding this comment

samiuelson Nov 20, 2024

Choose a reason for hiding this comment

AnirudhBhat Nov 21, 2024

Choose a reason for hiding this comment

AnirudhBhat commented Nov 12, 2024 •

edited

Loading

wpmobilebot commented Nov 12, 2024 •

edited

Loading

codecov-commenter commented Nov 15, 2024 •

edited

Loading