-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Products] Extract subscriptions outside of the Product DB table - Part 2 #12767
Conversation
and doesn't do any short-circuiting, so it's less performant.
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
035628d
to
feabdfb
Compare
feabdfb
to
f7e6c34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! I tested adding and updating subscription products and everything worked as expected. Also code changes look good. 🏅
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12767 +/- ##
============================================
- Coverage 40.88% 40.87% -0.01%
- Complexity 5771 5773 +2
============================================
Files 1237 1237
Lines 69745 69762 +17
Branches 9673 9680 +7
============================================
+ Hits 28513 28518 +5
- Misses 38604 38617 +13
+ Partials 2628 2627 -1 ☔ View full report in Codecov by Sentry. |
Closes: #12752
Description
This PR builds on top of what was added in #12766, it adds the saving logic, it updates both
addProduct
andupdateProduct
functions to handle passing the changed subscription details too.Steps to reproduce
Testing information
The tests that have been performed
^
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: