-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] POS avalability check optimisation #12759
[Woo POS] POS avalability check optimisation #12759
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12759 +/- ##
=========================================
Coverage 40.86% 40.86%
+ Complexity 5757 5751 -6
=========================================
Files 1236 1236
Lines 69722 69726 +4
Branches 9668 9669 +1
=========================================
+ Hits 28490 28496 +6
+ Misses 38604 38602 -2
Partials 2628 2628 ☔ View full report in Codecov by Sentry. |
…e-takes-more-time-than-it-should
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks for optimizing this, nice idea, and the difference is visible.
Closes: #12633
Description
Currently, there are two slow tasks we run to determine POS availability:
Those are run in sequential order, so in the worst-case scenario, it takes 4400ms to determine if POS is available.
The PR changes to run the heavy tasks in parallel, reducing the time in the case scenario to ~3300
Testing information
Open more -> Notice faster determination of the POS availability
The tests that have been performed
^
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: