Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shipping Revamp] Introduce Package selection flow #12757

Draft
wants to merge 22 commits into
base: issue/creating-shipping-label-add-products-cards
Choose a base branch
from

Conversation

ThomazFB
Copy link
Contributor

@ThomazFB ThomazFB commented Oct 3, 2024

Closes: #

Description

Steps to reproduce

Testing information

The tests that have been performed

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@ThomazFB ThomazFB added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Oct 3, 2024
@ThomazFB ThomazFB linked an issue Oct 3, 2024 that may be closed by this pull request
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 3, 2024

2 Errors
🚫 Please add tests for class WooShippingLabelsPackageCreationViewModel (or add unit-tests-exemption label to ignore this).
🚫 Please add tests for class ViewState (or add unit-tests-exemption label to ignore this).
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 3, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commite70de84
Direct Downloadwoocommerce-wear-prototype-build-pr12757-e70de84.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 3, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commite70de84
Direct Downloadwoocommerce-prototype-build-pr12757-e70de84.apk

@ThomazFB ThomazFB changed the base branch from trunk to issue/creating-shipping-label-add-products-cards October 22, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding package UI
3 participants