Update Android Material from 1.9.0 to 1.10.0 #12186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found 1 violations: The PR caused the following dependency changes:expand
-+--- com.google.android.material:material:1.6.1 -> 1.9.0
-| +--- com.google.errorprone:error_prone_annotations:2.15.0 -> 2.26.1
-| +--- androidx.annotation:annotation:1.2.0 -> 1.7.0 (*)
-| +--- androidx.appcompat:appcompat:1.5.0 -> 1.6.1 (*)
-| +--- androidx.cardview:cardview:1.0.0
-| | \--- androidx.annotation:annotation:1.0.0 -> 1.7.0 (*)
-| +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0
-| | +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
-| | +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
-| | +--- androidx.customview:customview:1.0.0 -> 1.1.0 (*)
-| | \--- androidx.collection:collection:1.0.0 -> 1.4.0 (*)
-| +--- androidx.constraintlayout:constraintlayout:2.0.1 -> 2.1.4 (*)
-| +--- androidx.core:core:1.6.0 -> 1.12.0 (*)
-| +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
-| +--- androidx.dynamicanimation:dynamicanimation:1.0.0
-| | +--- androidx.core:core:1.0.0 -> 1.12.0 (*)
-| | +--- androidx.collection:collection:1.0.0 -> 1.4.0 (*)
-| | \--- androidx.legacy:legacy-support-core-utils:1.0.0 (*)
-| +--- androidx.annotation:annotation-experimental:1.0.0 -> 1.3.1 (*)
-| +--- androidx.fragment:fragment:1.2.5 -> 1.6.2 (*)
-| +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.6.2 (*)
-| +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
-| +--- androidx.transition:transition:1.2.0 -> 1.4.1
-| | +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
-| | +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
-| | \--- androidx.collection:collection:1.1.0 -> 1.4.0 (*)
-| +--- androidx.vectordrawable:vectordrawable:1.1.0 (*)
-| \--- androidx.viewpager2:viewpager2:1.0.0 -> 1.1.0-beta02
-| +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
-| +--- androidx.annotation:annotation-experimental:1.3.0 -> 1.3.1 (*)
-| +--- androidx.collection:collection:1.1.0 -> 1.4.0 (*)
-| +--- androidx.core:core:1.3.2 -> 1.12.0 (*)
-| +--- androidx.fragment:fragment:1.1.0 -> 1.6.2 (*)
-| \--- androidx.recyclerview:recyclerview:1.3.1-rc01 -> 1.3.2 (*)
++--- com.google.android.material:material:1.10.0
+| +--- org.jetbrains.kotlin:kotlin-bom:1.8.22
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.25 (c)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.8.22 -> 1.9.10 (c)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.22 -> 1.9.10 (c)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.22 -> 1.9.25 (c)
+| | \--- org.jetbrains.kotlin:kotlin-reflect:1.8.22 (c)
+| +--- com.google.errorprone:error_prone_annotations:2.15.0 -> 2.26.1
+| +--- androidx.activity:activity:1.8.0 (*)
+| +--- androidx.annotation:annotation:1.2.0 -> 1.7.0 (*)
+| +--- androidx.appcompat:appcompat:1.6.1 (*)
+| +--- androidx.cardview:cardview:1.0.0
+| | \--- androidx.annotation:annotation:1.0.0 -> 1.7.0 (*)
+| +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0
+| | +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
+| | +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
+| | +--- androidx.customview:customview:1.0.0 -> 1.1.0 (*)
+| | \--- androidx.collection:collection:1.0.0 -> 1.4.0 (*)
+| +--- androidx.constraintlayout:constraintlayout:2.0.1 -> 2.1.4 (*)
+| +--- androidx.core:core:1.6.0 -> 1.12.0 (*)
+| +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
+| +--- androidx.dynamicanimation:dynamicanimation:1.0.0
+| | +--- androidx.core:core:1.0.0 -> 1.12.0 (*)
+| | +--- androidx.collection:collection:1.0.0 -> 1.4.0 (*)
+| | \--- androidx.legacy:legacy-support-core-utils:1.0.0 (*)
+| +--- androidx.annotation:annotation-experimental:1.0.0 -> 1.3.1 (*)
+| +--- androidx.fragment:fragment:1.2.5 -> 1.6.2 (*)
+| +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.6.2 (*)
+| +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
+| +--- androidx.resourceinspection:resourceinspection-annotation:1.0.1 (*)
+| +--- androidx.transition:transition:1.2.0 -> 1.4.1
+| | +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
+| | +--- androidx.core:core:1.1.0 -> 1.12.0 (*)
+| | \--- androidx.collection:collection:1.1.0 -> 1.4.0 (*)
+| +--- androidx.vectordrawable:vectordrawable:1.1.0 (*)
+| \--- androidx.viewpager2:viewpager2:1.0.0 -> 1.1.0-beta02
+| +--- androidx.annotation:annotation:1.1.0 -> 1.7.0 (*)
+| +--- androidx.annotation:annotation-experimental:1.3.0 -> 1.3.1 (*)
+| +--- androidx.collection:collection:1.1.0 -> 1.4.0 (*)
+| +--- androidx.core:core:1.3.2 -> 1.12.0 (*)
+| +--- androidx.fragment:fragment:1.1.0 -> 1.6.2 (*)
+| \--- androidx.recyclerview:recyclerview:1.3.1-rc01 -> 1.3.2 (*)
+--- androidx.navigation:navigation-ui-ktx:2.7.7
| \--- androidx.navigation:navigation-ui:2.7.7
-| \--- com.google.android.material:material:1.4.0-beta01 -> 1.9.0 (*)
+| \--- com.google.android.material:material:1.4.0-beta01 -> 1.10.0 (*)
+--- org.wordpress:utils:3.5.0
-| \--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
+| \--- com.google.android.material:material:1.2.1 -> 1.10.0 (*)
+--- org.wordpress:login:1.17.0
-| \--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
+| \--- com.google.android.material:material:1.2.1 -> 1.10.0 (*)
+--- com.github.wordpress-mobile.WordPress-Aztec-Android:aztec:v1.3.45
-| \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
+| \--- com.google.android.material:material:1.0.0 -> 1.10.0 (*)
+--- project :libs:cardreader
| \--- com.stripe:stripeterminal-localmobile:3.1.1
-| \--- com.google.android.material:material:1.9.0 (*)
+| \--- com.google.android.material:material:1.9.0 -> 1.10.0 (*)
+--- com.automattic:about:0.0.6
-| +--- com.google.android.material:material:1.4.0 -> 1.9.0 (*)
+| +--- com.google.android.material:material:1.4.0 -> 1.10.0 (*)
| \--- com.google.android.material:compose-theme-adapter:1.1.1
-| \--- com.google.android.material:material:1.6.0-alpha01 -> 1.9.0 (*)
+| \--- com.google.android.material:material:1.6.0-alpha01 -> 1.10.0 (*)
+--- com.zendesk:support:5.0.8
| +--- com.zendesk:guide:1.0.7
| | +--- com.zendesk:messaging:5.2.3
| | | +--- com.zendesk:common-ui:4.0.3
| | | | +--- com.zendesk.belvedere2:belvedere:3.0.0-RC
-| | | | | \--- com.google.android.material:material:1.2.0 -> 1.9.0 (*)
+| | | | | \--- com.google.android.material:material:1.2.0 -> 1.10.0 (*)
-| | | | \--- com.google.android.material:material:1.4.0 -> 1.9.0 (*)
+| | | | \--- com.google.android.material:material:1.4.0 -> 1.10.0 (*)
-| | | \--- com.google.android.material:material:1.4.0 -> 1.9.0 (*)
+| | | \--- com.google.android.material:material:1.4.0 -> 1.10.0 (*)
-| | \--- com.google.android.material:material:1.4.0 -> 1.9.0 (*)
+| | \--- com.google.android.material:material:1.4.0 -> 1.10.0 (*)
-| \--- com.google.android.material:material:1.4.0 -> 1.9.0 (*)
+| \--- com.google.android.material:material:1.4.0 -> 1.10.0 (*)
\--- org.wordpress:mediapicker:0.3.1
- +--- com.google.android.material:material:1.6.1 -> 1.9.0 (*)
+ +--- com.google.android.material:material:1.6.1 -> 1.10.0 (*)
\--- com.google.dagger:hilt-android-compiler:2.46.1
\--- com.google.dagger:dagger-compiler:2.46.1
\--- com.squareup:kotlinpoet:1.11.0
- \--- org.jetbrains.kotlin:kotlin-reflect:1.6.10
- \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.25 (*)
+ \--- org.jetbrains.kotlin:kotlin-reflect:1.6.10 -> 1.8.22
+ \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 1.9.25 (*)
Please review and act accordingly
|
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
AnirudhBhat
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Thanks for updating the library @malinajirka I smoke tested the app and it looks good to me 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Android Material library from version 1.9.0 to 1.10.0. In the code it seems we are upgrading from 1.6.1, but thanks to how transitive dependencies and gradle conflict resolution works, in reality we have been using version 1.9.0. You can verify this in the diff-tree-summary below.
The reason for this update is that we want to update Stripe Terminal SDK, which bumps this version to 1.10.0. Following the best practices - 🎩 hattip to @ParaskP7 - I'm updating an explicitly declared dependency in a separate PR.
The release notes can be found here. Notice they mention a known issue which is caused by the fact that 1.10.0 relies on AppCompat 1.6.1 which contains a bug - however, our app has already been using AppCompat 1.6.1 so this shouldn't affect this PR.
This PR also updates a transitive dependency - kotlin-reflect from 1.6.10 to 1.9.25. However, I haven't been able to find a standalone changelog for this library. Considering we are not using reflection directly in the app - just through dependencies - I believe this change is safe.
Testing information
Smoke test critical flows of the app - this update shouldn't theoretically break behavior, just animations/ui, but it's better to be safe and test it.
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.