Skip to content

Commit

Permalink
Deps: Migrate bumptech glide to version catalogs on woocommerce
Browse files Browse the repository at this point in the history
FYI: This change also drops the '@aar' suffix requirement, as the per
the 'Glide v4 Volley' documentation.

PS: The only difference between having the '@aar' suffix and not having
it, is the fact that not having it also bring in transitive
dependencies related to that 'volley-integration' dependency.
  • Loading branch information
ParaskP7 committed Oct 4, 2024
1 parent a0eb362 commit 8893f9a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
6 changes: 3 additions & 3 deletions WooCommerce/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -319,9 +319,9 @@ dependencies {

implementation(libs.mpandroidchart)

implementation "com.github.bumptech.glide:glide:$glideVersion"
ksp "com.github.bumptech.glide:compiler:$glideVersion"
implementation "com.github.bumptech.glide:volley-integration:$glideVersion@aar"
implementation(libs.bumptech.glide.main)
ksp(libs.bumptech.glide.compiler)
implementation(libs.bumptech.glide.volley.integration)
implementation 'com.google.android.play:app-update:2.1.0'
implementation 'com.google.android.play:review:2.0.1'

Expand Down
1 change: 0 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ tasks.register("installGitHooks", Copy) {
}

ext {
glideVersion = '4.16.0'
coilVersion = '2.1.0'
constraintLayoutVersion = '1.2.0'
eventBusVersion = '3.3.1'
Expand Down
4 changes: 4 additions & 0 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ androidx-work = '2.7.1'
automattic-about = '0.0.6'
automattic-tracks = '5.0.0'
assertj = '3.24.1'
bumptech-glide = '4.16.0'
facebook-shimmer = '0.5.0'
google-firebase-bom = '32.7.1'
google-material = '1.12.0'
Expand Down Expand Up @@ -79,6 +80,9 @@ automattic-about = { group = "com.automattic", name = "about", version.ref = "au
automattic-tracks-android = { group = "com.automattic", name = "Automattic-Tracks-Android", version.ref = "automattic-tracks" }
automattic-tracks-experimentation = { group = "com.automattic.tracks", name = "experimentation", version.ref = "automattic-tracks" }
automattic-tracks-crashlogging = { group = "com.automattic.tracks", name = "crashlogging", version.ref = "automattic-tracks" }
bumptech-glide-main = { group = "com.github.bumptech.glide", name = "glide", version.ref = "bumptech-glide" }
bumptech-glide-compiler = { group = "com.github.bumptech.glide", name = "compiler", version.ref = "bumptech-glide" }
bumptech-glide-volley-integration = { group = "com.github.bumptech.glide", name = "volley-integration", version.ref = "bumptech-glide" }
facebook-shimmer = { group = "com.facebook.shimmer", name = "shimmer", version.ref = "facebook-shimmer" }
google-firebase-analytics = { group = "com.google.firebase", name = "firebase-analytics" }
google-firebase-bom = { group = "com.google.firebase", name = "firebase-bom", version.ref = "google-firebase-bom" }
Expand Down

0 comments on commit 8893f9a

Please sign in to comment.