Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Update Storybook to latest #5105

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Update Storybook to latest #5105

merged 2 commits into from
Sep 8, 2020

Conversation

haszari
Copy link
Member

@haszari haszari commented Sep 8, 2020

Fixes #5103

Storybook has a new major version out, and the APIs & recommended addons are evolving, so I think it's a good idea to proactively keep up to date. This PR updates Storybook to latest, but doesn't adopt any new features or change existing stories - that can come later.

Screenshots

Screen Shot 2020-09-08 at 1 56 41 PM

Detailed test instructions:

  • Get on this branch.
  • Update dependencies, e.g. npm install.
  • Build & run storybook: npm run storybook.
  • Browse storybook and confirm everything's working correctly.

Bonus points: try adding a new story or adding more examples to an existing story.

Changelog Note:

n/a (no merchant facing change/impact) ?

Copy link
Contributor

@jeffstieler jeffstieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The styles seems a little off, though admittedly it's been a while since I've checked out our Storybook. It seems to be broken on main for me, so let's get this landed. 🚢 it!

@haszari haszari merged commit 0a51149 into main Sep 8, 2020
@haszari haszari deleted the update/storybook-6 branch September 8, 2020 19:54
@haszari
Copy link
Member Author

haszari commented Sep 8, 2020

The styles seems a little off, though admittedly it's been a while since I've checked out our Storybook. It seems to be broken on main for me, so let's get this landed.

Agreed, we really need to get this building off master automatically to keep it alive!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Storybook to latest (6.0+)
3 participants