Update wordpress monorepo #2929

renovate · 2019-09-18T02:29:08Z

This PR contains the following updates:

Package	Type	Update	Change
@wordpress/browserslist-config	devDependencies	minor	`2.4.0` -> `2.6.0`
@wordpress/components	dependencies	minor	`8.0.0` -> `8.3.1`
@wordpress/compose	dependencies	minor	`3.3.0` -> `3.7.1`
@wordpress/custom-templated-path-webpack-plugin	devDependencies	minor	`1.3.0` -> `1.5.0`
@wordpress/data	dependencies	minor	`4.5.0` -> `4.9.1`
@wordpress/date	dependencies	minor	`3.3.0` -> `3.5.0`
@wordpress/element	dependencies	minor	`2.4.0` -> `2.8.1`
@wordpress/hooks	dependencies	minor	`2.3.0` -> `2.6.0`
@wordpress/html-entities	dependencies	minor	`2.3.0` -> `2.5.0`
@wordpress/i18n	dependencies	minor	`3.4.0` -> `3.6.1`
@wordpress/jest-preset-default	devDependencies	minor	`4.1.0` -> `4.3.0`
@wordpress/keycodes	dependencies	minor	`2.3.0` -> `2.6.1`
@wordpress/notices	dependencies	minor	`1.5.0` -> `1.8.1`
@wordpress/scripts	dependencies	minor	`3.2.1` -> `3.4.0`
@wordpress/url	dependencies	minor	`2.6.0` -> `2.8.0`
@wordpress/viewport	dependencies	minor	`2.4.0` -> `2.8.1`

Release Notes

WordPress/gutenberg

`v2.6.0`

Compare Source

`v2.5.0`

Compare Source

Renovate configuration

📅 Schedule: "before 3am on wednesday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

renovate · 2019-10-07T18:34:47Z

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

psealock

Hey @justinshreve, I found an issue with the Compare button styles.

Do you think we need to review how we theme and style these buttons across the app?

client/header/activity-panel/activity-card/style.scss

client/analytics/report/style.scss

justinshreve · 2019-10-08T19:51:19Z

Do you think we need to review how we theme and style these buttons across the app?

I think it might be worth a more thorough review of how the PostCSS / colors are injected by Gutenberg, so we can make sure we are doing the right thing. The update here seemed to handle them differently from past versions.

It might also be worth a review of our usage to make sure we are using the correct button type in the correct places (primary / pink or default / gray).

I think the updated CSS I just pushed should style everything correctly now, and would allow us to unblock the version update.

psealock

I think the updated CSS I just pushed should style everything correctly now, and would allow us to unblock the version update.

yes, its looking good to me. Thanks for seeing this one through @justinshreve 🚢

Found another bug

justinshreve · 2019-10-11T13:46:33Z

Unfortunately I found another bug that needs fixing when testing parts of the application:

When selecting a custom date using the date range filter, selecting a calendar day entry or using the navigation arrows immediately closes the date picker. This does not happen on master.

justinshreve · 2019-10-14T15:42:58Z

@jeffstieler I didn't quite get this one all the way through last week. Do you mind adopting it and checking out the date picker bug?

nerrad · 2019-10-16T01:21:05Z

The datepicker issue should be fixed with a2fd4ce. @jeffstieler had narrowed it down to it being an issue between react-dates triggering a blur event on the mouseup event when clicking the month navigation arrows (originating in the react-dates DayPickerNavigation component) which in turn triggered a focus change. This in turn triggered the close of the Dropdown due to this code:

https://github.com/WordPress/gutenberg/blob/master/packages/components/src/dropdown/index.js#L48-L66

Jeff found this pull which fixed a similar issue happening in Gutenberg core. However, the fix there didn't quite work exactly the same in our case. I'm still not sure why doing the same thing wouldn't work here, but I did eventually realize that we could hook in on the onBlur event in the wrapping div to catch the blur bubbling up and restore focus before it got to the wrapping components.

My testing seemed to indicate all is working okay but could use additional eyes and a round of testing to verify.

jeffstieler · 2019-10-16T15:14:22Z

@nerrad thanks for that fix! 🙌 I had gotten close, but was definitely missing the onBlur piece.

In testing it seems that the dropdown modal no longer closes when clicking outside, so I'll try to restore that functionality.

jeffstieler · 2019-10-16T22:23:47Z

I think I've got a solution for the <DateRange> focus issue. This will need a review. 😄

psealock

This is testing well for me, besides the keyboard aspect noted below. Nice work getting to this point.

The keyboard navigation issue deserves some attention and hopefully there is a solution.

psealock · 2019-10-18T01:11:57Z

packages/components/src/calendar/date-range.js

+				<div
+					className="woocommerce-calendar__react-dates"
+					ref={ this.nodeRef }
+					onBlur={ partial( this.keepFocusInside, CONTAINER_DIV ) }


Keyboard navigation doesn't let you tab past the first arrow 😭 . I'm not sure how to distinguish a blur event via keyboard navigation from blur event via mouse. Here is a suggestion for setting a flag 🤷‍♀

In any case, until an upstream change happens to react-dates, I think this is an acceptable tradeoff considering the inputs are accessible.

Keyboard navigation should be fixed with d03971b.

The one questionable bit is the addition of a losesFocusTo prop to DateRange. It allows the tabbing to continue past the calendar grid and into the comparison period selector.

psealock

Nice one Jeff, I never knew about event.relatedTarget!

I agree the added prop losesFocusTo isn't ideal. In theory, this is temporary code though.

In any case, this is testing well with the keyboard. Just a comment about a leftover console.log.

psealock · 2019-10-22T23:03:48Z

packages/components/src/calendar/date-range.js

+				return;
+			}
+
+			console.log( 'looks like a mouseUp() blur', e );


Left a console.log in here

Fixed in 5e06c5a.

…onents update)

…ehavior.

- this fixed tests after an npm install on my end

Add prop for specifying an element that's allowed to take focus from DateRange.

probot-autolabeler bot added tool: monorepo infrastructure focus: components Issues for woocommerce components Packages labels Sep 18, 2019

renovate bot force-pushed the renovate/wordpress-monorepo branch 4 times, most recently from 10b4d76 to be58c1e Compare September 30, 2019 18:55

renovate bot changed the title ~~Update wordpress monorepo~~ chore(deps): update wordpress monorepo Sep 30, 2019

renovate bot changed the title ~~chore(deps): update wordpress monorepo~~ Update wordpress monorepo Oct 1, 2019

renovate bot force-pushed the renovate/wordpress-monorepo branch 2 times, most recently from da8050b to cedbb96 Compare October 7, 2019 18:03

psealock reviewed Oct 8, 2019

View reviewed changes

client/header/activity-panel/activity-card/style.scss Outdated Show resolved Hide resolved

client/analytics/report/style.scss Outdated Show resolved Hide resolved

justinshreve force-pushed the renovate/wordpress-monorepo branch from 13a746b to 31ab471 Compare October 9, 2019 14:15

justinshreve self-assigned this Oct 9, 2019

psealock previously approved these changes Oct 11, 2019

View reviewed changes

psealock added the [Status] Ready to Merge label Oct 11, 2019

justinshreve force-pushed the renovate/wordpress-monorepo branch 2 times, most recently from 17523e2 to 88decea Compare October 11, 2019 13:35

justinshreve removed the [Status] Ready to Merge label Oct 11, 2019

jeffstieler self-assigned this Oct 14, 2019

psealock added the [Status] Needs Review label Oct 16, 2019

psealock reviewed Oct 18, 2019

View reviewed changes

psealock approved these changes Oct 22, 2019

View reviewed changes

jeffstieler force-pushed the renovate/wordpress-monorepo branch from d03971b to 5e06c5a Compare October 23, 2019 15:21

renovate-bot and others added 12 commits October 23, 2019 08:27

Update wordpress monorepo

c82ab46

Add missing Gutenberg grid variables

cf045cb

Fix button styling

c558409

Fix snapshots (new classes and events are passed through from WP comp…

685acad

…onents update)

Adjust button overwrites

d58f2e3

Update package-lock.json

e4b0a06

Fix focus issues/conflicts with react-dates and Dropdown

9037864

Maintain DateRange focus without impacting expected "click outside" b…

920523f

…ehavior.

Resolve multiple React versions, update testing dependencies.

7bb8390

blow away package-lock.json and refresh

7505df5

- this fixed tests after an npm install on my end

Allow tabbing to month nav and calendar grid.

1704f58

Fix keyboard navigation of DayPicker elements.

8932e41

Add prop for specifying an element that's allowed to take focus from DateRange.

jeffstieler force-pushed the renovate/wordpress-monorepo branch from 5e06c5a to 8932e41 Compare October 23, 2019 15:45

refresh package-lock

7d04088

jeffstieler added [Status] Ready to Merge and removed [Status] Needs Review labels Oct 23, 2019

jeffstieler merged commit 23a28b3 into master Oct 23, 2019

jeffstieler deleted the renovate/wordpress-monorepo branch October 23, 2019 18:18

fylgjur mentioned this pull request Feb 11, 2021

ChunkLoadError with react-dom.min.js, WC back end does not load correctly since WC 5.0 #6323

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update wordpress monorepo #2929

Update wordpress monorepo #2929

renovate bot commented Sep 18, 2019 •

edited

Loading

renovate bot commented Oct 7, 2019

psealock left a comment

justinshreve commented Oct 8, 2019

psealock left a comment

justinshreve commented Oct 11, 2019

justinshreve commented Oct 14, 2019

nerrad commented Oct 16, 2019 •

edited

Loading

jeffstieler commented Oct 16, 2019

jeffstieler commented Oct 16, 2019 •

edited

Loading

psealock left a comment

psealock Oct 18, 2019

jeffstieler Oct 22, 2019

psealock left a comment

psealock Oct 22, 2019

jeffstieler Oct 23, 2019

Update wordpress monorepo #2929

Update wordpress monorepo #2929

Conversation

renovate bot commented Sep 18, 2019 • edited Loading

Release Notes

v2.6.0

v2.5.0

Renovate configuration

renovate bot commented Oct 7, 2019

PR has been edited

psealock left a comment

Choose a reason for hiding this comment

justinshreve commented Oct 8, 2019

psealock left a comment

Choose a reason for hiding this comment

justinshreve commented Oct 11, 2019

justinshreve commented Oct 14, 2019

nerrad commented Oct 16, 2019 • edited Loading

jeffstieler commented Oct 16, 2019

jeffstieler commented Oct 16, 2019 • edited Loading

psealock left a comment

Choose a reason for hiding this comment

psealock Oct 18, 2019

Choose a reason for hiding this comment

jeffstieler Oct 22, 2019

Choose a reason for hiding this comment

psealock left a comment

Choose a reason for hiding this comment

psealock Oct 22, 2019

Choose a reason for hiding this comment

jeffstieler Oct 23, 2019

Choose a reason for hiding this comment

renovate bot commented Sep 18, 2019 •

edited

Loading

`v2.6.0`

`v2.5.0`

nerrad commented Oct 16, 2019 •

edited

Loading

jeffstieler commented Oct 16, 2019 •

edited

Loading