New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't break URL just because HTTP is used without parameters. #101

Open

bigretromike wants to merge 1 commit into woocommerce:trunk from bigretromike:trunk

bigretromike commented Jun 7, 2024

While using http connection without extra parameters url constructor add undesired "?"
example:

wcapi.get("/products?sku=test")

with http connection will become:

http://example.domain/wp-json/wc/v3/products?sku=test%3F&oauth_consumer_key=ck_xxx&oauth_timestamp=1717745432&oauth_nonce=12afaxxx&oauth_signature_method=HMAC-SHA256&oauth_signature=kxxxx

after test there is added ? then its coded with parameters (or the absense of them) as %3F which breaks api.


          Don't allow to break AUTH string;

d6aa14e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet