Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary position in on sale #2120

Closed
wants to merge 1 commit into from
Closed

Remove unnecessary position in on sale #2120

wants to merge 1 commit into from

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Aug 11, 2023

This PR updates the CSS fix position introduced in #2118

Screenshots

image

How to test the changes in this Pull Request:

  1. Ensure you have a WooCommerce Blocks with Create wc-all-block-styles chunk with all blocks stylesheet for classic themes woocommerce-blocks#10543.
  2. Open the post editor.
  3. Add the Hand-picked Products and select a sale product.
  4. Save.
  5. Visit the page.
  6. Check the Sale badge shows on the right position.

@albarin albarin closed this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@albarin