Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docblocks to hooks used in customizer class. #2038

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

danielwrobert
Copy link
Contributor

Summary

Committing was prevented if edits were made to the inc/customizer/class-storefront-customizer.php file because there were several hooks used in the file without docblocks.

Test plan

  1. In your Terminal application run ./vendor/bin/phpcs /Users/danielrobert/Projects/automattic/woo/woo-dev/wp-content/themes/storefront/inc/customizer/class-storefront-customizer.php.
  2. Confirm no errors are output.

Changelog

Fix – Add missing docblocks to theme's customizer class.

This resolves PHP linting errors.
@danielwrobert danielwrobert self-assigned this Sep 7, 2022
@danielwrobert danielwrobert requested a review from a team as a code owner September 7, 2022 19:40
@danielwrobert danielwrobert requested review from danieldudzic and removed request for a team September 7, 2022 19:40
Minor update to fix `Equals sign not aligned correctly; expected 1 space
but found X spaces` warnings.
Copy link
Contributor

@danieldudzic danieldudzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label Sep 9, 2022
@danielwrobert danielwrobert merged commit c18cd6e into trunk Sep 9, 2022
@danielwrobert danielwrobert deleted the fix/php-lint-errors branch September 9, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants