-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accent color to WC Blocks price slider #1508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those changes are not being honoured on the editor, this can be addressed in a follow-up.
On initially loading this PR, I see this on frontend
In the editor, I see this:
When changing a color, the result is reflected on the frontend, but not the editor.
On trunk, I can see the new purple on both editor and frontend, so I don't know why is the frontend using old purple in this PR.
I missed this step
|
After doing that step, I'm still seeing this issue in the editor (color not being respected). |
a71f524
to
07f5846
Compare
Good catch @senadir! I fixed this in 07f5846. The issue was affecting other blocks like Cart and Checkout (they were not honoring the button color in the editor). I moved the CSS of all blocks so it should be fixed in all.
Ah, sorry, I just updated the PR to remove that step. It's no longer needed since that PR was merged into WC Blocks. |
I will proceed merging this since it has already been approved and this way it gets in |
This PR adds styles to the price slider of the Filter Products by Price block. It requires the changes in woocommerce/woocommerce-blocks#3300, which decrease the selector specificity of the default styles.
Screenshots
Customizer
Child theme
(Screenshots with Bistro)
Before:
After:
How to test the changes in this Pull Request:
Changelog