Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve a few E2E test cases #2769

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Improve a few E2E test cases #2769

merged 5 commits into from
Jan 16, 2025

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Jan 16, 2025

Changes proposed in this Pull Request:

This PR improves a few E2E test cases:

💡 I will be skipping code review since this PR only includes developer-facing only change.

Detailed test instructions:

Confirm E2E tests can pass: https://github.com/woocommerce/google-listings-and-ads/actions/runs/12804583366

Changelog entry

@eason9487 eason9487 self-assigned this Jan 16, 2025
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.7%. Comparing base (f25f66c) to head (a3a0a7a).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2769      +/-   ##
============================================
- Coverage       67.1%   66.7%    -0.4%     
============================================
  Files            796     316     -480     
  Lines          24493    4922   -19571     
  Branches        1204    1204              
============================================
- Hits           16441    3282   -13159     
+ Misses          7915    1503    -6412     
  Partials         137     137              
Flag Coverage Δ
js-unit-tests 66.7% <ø> (ø)
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 480 files with indirect coverage changes

@eason9487 eason9487 merged commit f88648c into develop Jan 16, 2025
10 checks passed
@eason9487 eason9487 deleted the dev/improve-e2e-tests branch January 16, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant