Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #736
This PR is an alternative to #784. #784 is a great solution if adding group exclusion were the only filter we were looking to add to the queue runners. However, we are considering adding:
#784 works around the limitation that we cannot modify the
claim_actions
function definition by embedding flags in existing parameters. While that works for one flag/parameter it isn't practical for adding several. This PR avoid that by adding a new function to the base tables DB store.It also lays the groundwork for adding additional filters. For example, excluding hooks will only require a few additional lines of code. Secondly, all added filters could be implemented on the async and cron runners through a settings screen without using similar parameter tampering.
Testing
Changelog