Bump min Flutter SDK version to 3.16.0 #343
Conversation
|
It appears that this PR does not include any tests. It is recommended to add tests, especially for critical changes, to ensure code quality and prevent regressions. However, if this PR is only updating samples or documentation, feel free to skip adding tests and disregard this comment. |
|
Taking a look at failures. |
|
It appears that this PR does not include any tests. It is recommended to add tests, especially for critical changes, to ensure code quality and prevent regressions. However, if this PR is only updating samples or documentation, feel free to skip adding tests and disregard this comment. |
|
@ulusoyca |
|
Link to the rule https://dcm.dev/docs/rules/common/avoid-suspicious-super-overrides/ |
|
@TahaTesser let's remove this rule. How about the failing tests? |
|
It appears that this PR does not include any tests. It is recommended to add tests, especially for critical changes, to ensure code quality and prevent regressions. However, if this PR is only updating samples or documentation, feel free to skip adding tests and disregard this comment. |
|
It appears that this PR does not include any tests. It is recommended to add tests, especially for critical changes, to ensure code quality and prevent regressions. However, if this PR is only updating samples or documentation, feel free to skip adding tests and disregard this comment. |
| @@ -24,5 +24,3 @@ scripts: | |||
| exec: dcm analyze . | |||
| format: | |||
| exec: dart format --set-exit-if-changed . | |||
| test: | |||
There was a problem hiding this comment.
Since example folders don't have a "test" folder and only in the root folder of the package, the melos test fails in the CI. However, this is fine to remove since GitHub check also runs flutter test directly in the root package folder.
Description
Bumps the min Flutter SDK version to 3.16.0
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?