Remove KeyboardVisibilityListener dependency and add WoltKeyboardClosureListenerMixin #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulusoyca
changed the title
ulusoyca
changed the title
moshe5745
reviewed
Aug 14, 2024
| with TickerProviderStateMixin { | ||
| with | ||
| TickerProviderStateMixin, | ||
| WidgetsBindingObserver, |
There was a problem hiding this comment.
Can delete this WidgetsBindingObserver mixin here
| /// was previously visible and is now hidden, it increments the event ID and updates | ||
| /// the notifier. | ||
| @override | ||
| void didChangeMetrics() { |
There was a problem hiding this comment.
At first i too used this in my first approach.
But then I saw that the MediaQuery is already listening to it.
And its enough just to listen to changes in didChangeDependencies() with MediaQuery.
I don't know what are the implications of this, maybe there arent any.
mukireus
reviewed
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
WoltKeyboardClosureListenerMixinmixin and removes the FlutterKeyboardVisibility package dependency. The purpose of this mixin is to track the visibility of the soft keyboard by monitoring the changes in the system's view insets and using the WidgetsBindingObserver.fix_keyboard_visibility.mp4
ios_keyboard.mov
Related Issues
#210
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?