Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevent dismiss on barrier tap for alert dialog #245

Conversation

durannumit
Copy link
Collaborator

Description

This PR addresses an issue where alert dialogs could be dismissed by tapping the barrier (the area outside the dialog). This behavior was unintended for alert dialogs, which typically require explicit user action to dismiss.

Before Dismiss on Barrier After Dismiss on Barrier
dismiss-on-barrier-tap-before.mov
dismiss-on-barrier-tap-after.mov

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@ulusoyca ulusoyca self-requested a review July 1, 2024 21:17
@ulusoyca ulusoyca merged commit 755b1e0 into woltapp:main Jul 1, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants