-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor]: Folder structure improvement proposal #345
Comments
Thanks for the proposal. We need the example folder separately AFAIK to be able to show this page on pub dev. Otherwise examples folder looks good. I would also like to keep widgetbook inside coffee_maker_navigator_2 since it belongs to that specific project. Other than than wolt_state_management and wolt_di also only used in coffee_maker_navigator_2. We should include them under it imo. |
Package layout conventions - Examples We can re-add the Widgetbook project as you suggested. I recommend moving the Edited: You can also check out the "example" section of the widgetbook package: Widgetbook example section on pub.dev |
Also you can check this PR: [DRAFT] Refactor - Clean folder structure |
@mukireus The draft PR looks good. We can merge this way. @TahaTesser what is your take? @mukireus we will also need to update the ReadMe. |
Looks good to me. This will make the samples navigation a lot better. I wanted to do this but couldn't get around it. |
* refactor: move coffee_maker example project from root to examples folder * refactor: move coffee_maker_navigator_2 example project from root to examples folder * refactor: move demo_ui_components example project from root to examples folder * refactor: move playground example project from root to examples folder * refactor: move playground_navigator2 example project from root to examples folder * refactor: move widgetbook example project from coffe_maker_navigator2 to examples folder * chore: update dependency paths in example projects for consistency * refactor: move wolt_di package from root to packages folder * refactor: move wolt_state_management package from root to packages folder * chore: update dependency paths in packages for consistency * Revert "refactor: move widgetbook example project from coffe_maker_navigator2 to examples folder" This reverts commit 28ca416. * chore: update paths on yaml files * doc: update README file
@ulusoyca Should we also move the |
@mukireus Thanks for the great changes, and the PR! This repo is made for Wolt Modal Sheet, the other packages are planned to be released a packages during next year in separate repos, so let's keep them under the packages folder for now. I am closing this issue. Once more, thanks for the great work. |
What feature would you like to see?
The current folder structure appears disorganized, with example projects and packages nested within each other. It is recommended to refactor the folder structure to provide better clarity and organization.
By restructuring the folder organization, users who only include this package in their projects will avoid downloading unused example files when executing
flutter pub get
. This change is expected to improve the performance of the command execution by reducing the amount of data that needs to be fetched.See
The text was updated successfully, but these errors were encountered: