Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second pull request attempt #227

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

JeffreyOI
Copy link

No description provided.

Added simple mesh (one triangle) to illustrate the structure of the mesh class. Some of this may belong in the src, but since everyone looks at the readme, I thought it helpful to do a little explanation here.
Missing setuptools installation. Causing AV check to fail.
@JeffreyOI JeffreyOI marked this pull request as draft October 16, 2024 06:12
@JeffreyOI JeffreyOI marked this pull request as ready for review October 16, 2024 06:19
@JeffreyOI JeffreyOI marked this pull request as draft October 16, 2024 06:26
@JeffreyOI JeffreyOI marked this pull request as ready for review October 16, 2024 06:26
@JeffreyOI JeffreyOI marked this pull request as draft October 17, 2024 05:41
@JeffreyOI JeffreyOI marked this pull request as ready for review October 17, 2024 05:41
@JeffreyOI JeffreyOI marked this pull request as draft October 17, 2024 05:48
@JeffreyOI JeffreyOI marked this pull request as ready for review October 17, 2024 05:48
@JeffreyOI JeffreyOI marked this pull request as draft October 17, 2024 15:20
@JeffreyOI JeffreyOI marked this pull request as ready for review October 17, 2024 15:20
@JeffreyOI JeffreyOI marked this pull request as draft October 17, 2024 15:25
@JeffreyOI JeffreyOI marked this pull request as ready for review October 17, 2024 15:26
@JeffreyOI JeffreyOI marked this pull request as draft October 17, 2024 15:44
@JeffreyOI JeffreyOI marked this pull request as ready for review October 17, 2024 15:44
@JeffreyOI JeffreyOI marked this pull request as draft October 17, 2024 15:58
@JeffreyOI JeffreyOI marked this pull request as ready for review October 17, 2024 15:58
@wolph
Copy link
Owner

wolph commented Oct 26, 2024

Wow, that's quite a lot of changes. I got to ask though, did you have issues without the bool(...) cast or was that simply the result of debugging?

Can you explain the purpose of this pull request? I see a nice addition to the readme and a few random changes that could be due to changes in my branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants