Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --path flag in update cmd #596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joemiller
Copy link
Contributor

@joemiller joemiller commented Jan 31, 2024

Recent changes have resulted in the wolfictl update --path flag breaking.

This flag allows for working with a repo where the melange yaml's are in a subdir such as ./packages of the repo.

ℹ️ | 2024/01/31 00:40:50 wolfictl update: attempt 1: failed to update packages in git repository: failed to parse open docker-compose.yaml: no such file or directory

A few of the new code paths required a relative path to work properly so I borrowed the filepath.Rel() pattern that melange.go was using.

@joemiller joemiller force-pushed the fix-update-path-arg branch from c8e1170 to 980e0a5 Compare January 31, 2024 00:57
@joemiller joemiller changed the title fix: --path flag in update fix: --path flag in update cmd Jan 31, 2024
@joemiller joemiller marked this pull request as draft January 31, 2024 01:29
@joemiller joemiller force-pushed the fix-update-path-arg branch from 980e0a5 to a30540c Compare January 31, 2024 01:36
@joemiller joemiller marked this pull request as ready for review January 31, 2024 01:37
@joemiller joemiller force-pushed the fix-update-path-arg branch from a30540c to a931165 Compare January 31, 2024 14:50
Recent changes have resulted in the `wolfictl update --path` flag
breaking.

This flag allows for working with a repo where the melange yaml's are in
a subdir such as `./packages` of the repo.

> ℹ️            | 2024/01/31 00:40:50 wolfictl update: attempt 1: failed to update packages in git repository: failed to parse open docker-compose.yaml: no such file or directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant