py3-pywinpty/2.0.14 package update

[octo-sts]

[octo-sts]

Gen AI suggestions to solve the build error:

The error message indicates a failure to resolve `Win32` in the `windows` crate. To fix this, ensure the `windows` crate is included in your `Cargo.toml`, verify the version supports `Win32`, check for correct feature flags, update the crate if necessary, and review import paths for accuracy.

[octo-sts]

Gen AI suggestions to solve the build error:

• Detected Error:

error[E0433]: failed to resolve: could not find `Win32` in `windows`
[...]
error: could not compile `winpty-rs` (lib) due to 9 previous errors

• Error Category: Build/Dependency

• Failure Point: Rust compilation of winpty-rs native extension

• Root Cause Analysis:
The package pywinpty is Windows-specific and attempts to compile Windows-dependent Rust code on a Linux system. The Windows-specific dependencies from the windows-rs crate cannot be resolved in a Linux build environment.

• Suggested Fix:
This package should be marked as Windows-only and should not be built on Linux systems. Modify the melange.yaml to skip build on Linux:

# Add at top level
conditions:
  if: ${{target.platform == "windows"}}

Or remove it entirely from the Linux build as it's not functional on Linux systems.

• Explanation:
pywinpty provides pseudo terminal support specifically for Windows systems using the Windows API through winpty. The Rust code explicitly depends on Windows-specific APIs (Win32) which cannot be cross-compiled on Linux systems. This package should only be built and distributed for Windows targets.

• Additional Notes:

• pywinpty is specifically designed for Windows pseudo-terminal support
• The package name itself indicates Windows specificity (winpty)
• There are Linux-native alternatives like 'pty' for Unix-like systems
• This package should not be included in Wolfi OS as it's Windows-specific

• References:

• PyPI package: https://pypi.org/project/pywinpty/
• Package Documentation: https://github.com/conda-forge/pywinpty-feedstock
• Similar Issue: pytest capture logging error still happening pytest-dev/pytest#5502 (Windows-specific packages in Linux environments)

[octo-sts]

Gen AI suggestions to solve the build error:

• Detected Error: The log doesn't show a direct error message, but the build appears to stop during Rust compilation of pyo3 dependencies for pywinpty

• Error Category: Platform Compatibility

• Failure Point: Building the Rust components of pywinpty package during pip wheel creation

• Root Cause Analysis: pywinpty is a Windows-specific package that provides pseudo terminal support for Windows. It cannot be built on Linux systems as it requires Windows-specific APIs and dependencies.

• Suggested Fix:

1. Add a platform restriction to skip building on Linux:

package:
  name: py3-pywinpty
  version: 2.0.14
  epoch: 0
  description: Pseudo terminal support for Windows from Python.
  copyright:
    - license: MIT
  # Add platform restriction
  arch:
    - disabled # Skip building on all architectures since this is Windows-only

• Explanation:

• pywinpty is specifically designed for Windows systems and uses Windows-specific APIs (winpty)
• The package cannot be built on Linux systems as it requires native Windows components
• Adding the arch: disabled directive will prevent the package from attempting to build on Linux systems
• This is the correct approach for Windows-only packages in Wolfi OS

• Additional Notes:

• pywinpty should only be packaged for Windows distributions
• For Linux systems, alternative packages like 'pty' or 'pseudoterminal' should be used instead
• The package's own documentation confirms it's Windows-specific: https://github.com/conda-forge/pywinpty-feedstock

• References:

• pywinpty GitHub: https://github.com/spyder-ide/pywinpty
• PyPI package: https://pypi.org/project/pywinpty/
• Upstream issue discussing Linux compatibility: PR: Wait (blocking) for data when using PtyProcess andfoy/pywinpty#95

[mamccorm]

Project has migrated from pip to pyproject.toml. For comparison:

• https://github.com/andfoy/pywinpty/tree/v2.0.13
• https://github.com/andfoy/pywinpty/tree/v2.0.14

Not currently sure how we update this package, conforming to the new python package standard

[pnasrat]

@mamccorm - this is a win32 only package (see upstream releases) and brought in mistakenly via jupyter-server when it was an os constrained dependency (currently ignored by melange convert) - this should be removed from any requiring packages eg jupyter-server and withdrawn from wolfi.

https://github.com/jupyter-server/jupyter_server/blob/535d7df3c0b358e31f514842c5509ca6ce64f056/pyproject.toml#L36

[pnasrat]

Looking why prior version builds and diffs

andfoy/pywinpty@v2.0.13...v2.0.14

Main dep changes are

[dependencies]
winpty-rs = "0.4"

[dependencies.pyo3]
version = "0.22.3"

The compile error is in winpty-rs

2024/12/09 07:50:38 WARN      Compiling winpty-rs v0.4.0 subpackage=py3.10-pywinpty uses=py/pip-build-install name="pip build"
2024/12/09 07:50:39 WARN   error[E0433]: failed to resolve: could not find `Win32` in `windows` subpackage=py3.10-pywinpty uses=py/pip-build-install name="pip build"
2024/12/09 07:50:39 WARN    --> /home/build/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winpty-rs-0.4.0/src/pty/base.rs:3:14 subpackage=py3.10-pywinpty uses=py/pip-build-install name="pip build"
2024/12/09 07:50:39 WARN     | subpackage=py3.10-pywinpty uses=py/pip-build-install name="pip build"
2024/12/09 07:50:39 WARN   3 | use windows::Win32::Foundation::{CloseHandle, HANDLE, STATUS_PENDING, S_OK, WAIT_FAILED, WAIT_OBJECT_0, WAIT_TIMEOUT}; subpackage=py3.10-pywinpty uses=py/pip-build-install name="pip build"
2024/12/09 07:50:39 WARN     |              ^^^^^ could not find `Win32` in `windows` subpackage=py3.10-pywinpty uses=py/pip-build-install name="pip build"

[pnasrat]

note the current package despite compiling is non-functional anyway

>>> from winpty import PtyProcess
>>> proc = PtyProcess.spawn('python3.12')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.12/site-packages/winpty/ptyprocess.py", line 94, in spawn
    proc = PTY(dimensions[1], dimensions[0],
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pywinpty.WinptyError: "\"There were some errors trying to instantiate a PTY:\" (ConPTY) -> \"pty_rs was compiled without ConPTY enabled\";" (WinPTY) -> "winpty_rs was compiled without WinPTY enabled"

[mamccorm]

PR to delete package and withdraw:

• remove py3-pywinpty which should never have been added, as it require… #36706

Once merged, this can be closed

[mamccorm]

closing, package deleted:
#36706