Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests, missing binaries and correct paths #17025

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

developer-guy
Copy link
Member

Fixes:

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

@developer-guy developer-guy force-pushed the actions-runner-controller branch 3 times, most recently from 722d0c7 to ba2d010 Compare April 17, 2024 09:34
Copy link
Contributor

@some-natalie some-natalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@developer-guy developer-guy force-pushed the actions-runner-controller branch 2 times, most recently from b3f33cb to 0d2aef1 Compare April 17, 2024 18:14
@developer-guy developer-guy requested a review from mamccorm April 17, 2024 18:42
@developer-guy developer-guy force-pushed the actions-runner-controller branch from 0d2aef1 to 44ec9fc Compare April 17, 2024 18:43
@developer-guy developer-guy requested a review from mamccorm April 17, 2024 19:46
@developer-guy developer-guy force-pushed the actions-runner-controller branch from 44ec9fc to f254e87 Compare April 17, 2024 19:46
@mamccorm mamccorm merged commit 5c6b7e2 into wolfi-dev:main Apr 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants