Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change optval type to match system #8204

Merged
merged 1 commit into from
Nov 21, 2024
Merged

change optval type to match system #8204

merged 1 commit into from
Nov 21, 2024

Conversation

JacobBarthelmeh
Copy link
Contributor

Found when reviewing this PR #8197

Linux:

man getsockopt

       int getsockopt(int sockfd, int level, int optname,
                      void *optval, socklen_t *optlen);

Windows

https://learn.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-getsockopt

int getsockopt(
  [in]      SOCKET s,
  [in]      int    level,
  [in]      int    optname,
  [out]     char   *optval,
  [in, out] int    *optlen
);

@dgarske
Copy link
Contributor

dgarske commented Nov 20, 2024

Retest this please: FAIL: scripts/ocsp-stapling_tls13multi.test

@dgarske
Copy link
Contributor

dgarske commented Nov 21, 2024

Retest this please. CRL issues

@douzzer douzzer merged commit 2710b57 into wolfSSL:master Nov 21, 2024
143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douzzer douzzer douzzer approved these changes

@dgarske dgarske dgarske approved these changes

Assignees

@JacobBarthelmeh JacobBarthelmeh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacobBarthelmeh @dgarske @douzzer