20240806-debug-trace-errcodes-backtrace #7846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
requested changes
Aug 7, 2024
* uses libbacktrace to enhance existing "ERR TRACE" messages with backtraces, rendered in same format as the sanitizers. * adds wc_backtrace_render() and some related callbacks to wolfcrypt/src/logging.c. * adds an overrideable WOLFSSL_DEBUG_BACKTRACE_RENDER_CLAUSE to the WC_ERR_TRACE() mechanism in wolfssl/wolfcrypt/error-crypt.h.
…ebug builds: null deref in tests/api.c:load_pem_key_file_as_der(), redundant declarations in wolfcrypt/benchmark/benchmark.c, and numerous unchecked XSNPRINTF()s in wolfcrypt/src/logging.c and src/internal.c.
…Check) in wc_KyberKey_MakeKeyWithRandom() and wc_KyberKey_Decapsulate() added in d350ba6.
… a buffer error rather than silently failing; in wc_backtrace_render(), fix !WOLFSSL_MUTEX_INITIALIZER race mitigation code.
douzzer
force-pushed
the
20240806-debug-trace-errcodes-backtrace
branch
from
755dfa1 to
24e34aa
Compare
bandi13
approved these changes
Aug 8, 2024
SparkiDev
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
--enable-debug-trace-errcodes=backtrace.* uses libbacktrace to enhance existing "ERR TRACE" messages with backtraces, rendered in same format as the sanitizers.
* adds
wc_backtrace_render()and some related callbacks towolfcrypt/src/logging.c.* adds an overrideable
WOLFSSL_DEBUG_BACKTRACE_RENDER_CLAUSEto theWC_ERR_TRACE()mechanism inwolfssl/wolfcrypt/error-crypt.h.also: fixes for defects identified by
cppcheckandclang-tidyon--enable-debugbuilds: null deref intests/api.c:load_pem_key_file_as_der(), redundant declarations inwolfcrypt/benchmark/benchmark.c, and numerous uncheckedXSNPRINTF()s inwolfcrypt/src/logging.candsrc/internal.c.tested with
wolfssl-multi-test.sh ... all-gcc-debug-c99-backtrace cppcheck-all-debug-backtrace clang-tidy-all-debug-backtrace super-quick-check. (*-backtraceare new optional scenarios added to test this PR.)note that use of this feature requires installation of libbacktrace into the build environment.
autoreconf -fi && ./configure && make && sudo make installworked for me.