Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20240728-EVP_PKEY_is_a #7804

Merged
merged 1 commit into from
Aug 14, 2024
Merged

20240728-EVP_PKEY_is_a #7804

merged 1 commit into from
Aug 14, 2024

Conversation

douzzer
Copy link
Contributor

@douzzer douzzer commented Jul 29, 2024

wolfcrypt/src/evp.c: add EVP_PKEY_is_a().

@douzzer douzzer requested a review from julek-wolfssl July 29, 2024 04:44
@douzzer douzzer force-pushed the 20240728-EVP_PKEY_is_a branch from 63f891f to bb4266c Compare July 29, 2024 05:04
@bandi13
Copy link
Contributor

bandi13 commented Jul 29, 2024

retest this please

julek-wolfssl
julek-wolfssl requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Needs some unit tests.

@douzzer douzzer force-pushed the 20240728-EVP_PKEY_is_a branch from bb4266c to 3524e15 Compare August 12, 2024 17:53
@douzzer douzzer requested a review from julek-wolfssl August 12, 2024 17:54
@douzzer
Copy link
Contributor Author

douzzer commented Aug 12, 2024

retest this please -- PRB-aarch64-tests-v2 testsuite "wolfSSL error: tcp connect failed: Connection refused"

@douzzer douzzer force-pushed the 20240728-EVP_PKEY_is_a branch from 3524e15 to 6173293 Compare August 12, 2024 22:55
@douzzer
Copy link
Contributor Author

douzzer commented Aug 13, 2024

retest this please

(unreproducible failure on PRB-fsanitize-addr-v3 ./configure --enable-jobserver=4 CC="clang -fsanitize=address,undefined -g" --enable-all --enable-sp-math-all FAIL: scripts/openssl.test)

@douzzer douzzer assigned julek-wolfssl and unassigned douzzer Aug 13, 2024
julek-wolfssl
julek-wolfssl requested changes Aug 13, 2024
View reviewed changes
Copy link
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final fixes and ready to merge.

wolfcrypt/src/evp.c Outdated Show resolved Hide resolved
wolfcrypt/src/evp.c Outdated Show resolved Hide resolved
wolfcrypt/src/evp.c Outdated Show resolved Hide resolved
@douzzer douzzer force-pushed the 20240728-EVP_PKEY_is_a branch from 6173293 to 84a484c Compare August 13, 2024 18:01
@douzzer douzzer requested a review from julek-wolfssl August 13, 2024 18:02
@douzzer douzzer assigned julek-wolfssl and unassigned douzzer Aug 13, 2024
julek-wolfssl
julek-wolfssl requested changes Aug 14, 2024
View reviewed changes
wolfcrypt/src/evp.c Outdated Show resolved Hide resolved
@julek-wolfssl julek-wolfssl mentioned this pull request Aug 14, 2024
Merged
@douzzer
wolfcrypt/src/evp.c: add wolfSSL_EVP_PKEY_is_a() and test_EVP_PKEY_is…
ee966be 
…_a(). also add test_EVP_CIPHER_key_length() and add missing RC4 clause to wolfSSL_EVP_Cipher_key_length().
@douzzer douzzer force-pushed the 20240728-EVP_PKEY_is_a branch from 84a484c to ee966be Compare August 14, 2024 14:23
@douzzer douzzer removed their assignment Aug 14, 2024
@douzzer douzzer requested a review from julek-wolfssl August 14, 2024 14:23
@julek-wolfssl julek-wolfssl merged commit 055d68d into wolfSSL:master Aug 14, 2024
117 of 124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julek-wolfssl julek-wolfssl julek-wolfssl approved these changes

Assignees

@julek-wolfssl julek-wolfssl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@douzzer @bandi13 @julek-wolfssl @wolfSSL-Bot