Code sonar cleanup #7782
Merged
Code sonar cleanup #7782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bandi13
commented
Jul 23, 2024
bandi13
force-pushed
the
CodeSonarCleanup
branch
3 times, most recently
from
bf96af6 to
f58c0cb
Compare
bandi13
force-pushed
the
CodeSonarCleanup
branch
from
f58c0cb to
6175778
Compare
SparkiDev
requested changes
Jul 23, 2024
|
Retest this please |
dgarske
requested changes
Jul 24, 2024
wolfssl/wolfcrypt/types.h
Outdated
| @@ -917,6 +917,7 @@ typedef struct w64wrapper { | |||
| WOLFSSL_API int wc_strncasecmp(const char *s1, const char *s2, size_t n); | |||
| #endif | |||
|
|
|||
| WOLFSSL_API char* wc_strdup(const char *src, int memType); | |||
There was a problem hiding this comment.
This should not be public... Please make WOLFSSL_LOCAL
wolfcrypt/src/wc_port.c
Outdated
| @@ -1177,6 +1177,21 @@ int wc_strncasecmp(const char *s1, const char *s2, size_t n) | |||
| } | |||
| #endif /* USE_WOLF_STRNCASECMP */ | |||
|
|
|||
| char* wc_strdup(const char *src, int memType) { | |||
There was a problem hiding this comment.
This should not be always exposed... It needs to be conditional based on #ifdef XGETENV or possibly another macro like USE_WOLF_STRDUP. I'd like to see this strdup function perfectly match the stdlib strdup API. Also consider fixing #define BUF_strdup strdup to use it...
bandi13
force-pushed
the
CodeSonarCleanup
branch
from
bbeb246 to
87386f2
Compare
SparkiDev
approved these changes
Jul 28, 2024
dgarske
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.