Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add global heap hint setter function #7478

Merged
merged 4 commits into from
May 15, 2024

Conversation

JacobBarthelmeh
Copy link
Contributor

No description provided.

@JacobBarthelmeh JacobBarthelmeh self-assigned this Apr 26, 2024
billphipps
billphipps previously approved these changes Apr 26, 2024
wolfcrypt/src/memory.c Outdated Show resolved Hide resolved
examples/client/client.c Outdated Show resolved Hide resolved
wolfcrypt/src/memory.c Show resolved Hide resolved
wolfssl/wolfcrypt/memory.h Outdated Show resolved Hide resolved
billphipps
billphipps previously approved these changes May 6, 2024
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is great. What's holding it up?



/* returns a pointer to the current global heap hint */
void* wolfSSL_GetGlobalHeapHint()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(void).

@JacobBarthelmeh
Copy link
Contributor Author

Restest this please Jenkins

@JacobBarthelmeh
Copy link
Contributor Author

I don't like that a retest needed done. Will need to keep an eye out for if the tests are having a threading issue with the setting of the global heap hint (is why I limited the set global heap hint test).

@dgarske dgarske self-requested a review May 15, 2024 17:18
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JacobBarthelmeh please make sure the static memory / user manual adds a few lines about these new APIs. Very handy addition.

@dgarske dgarske merged commit ac7aea9 into wolfSSL:master May 15, 2024
99 checks passed
jefferyq2 pushed a commit to jefferyq2/wolfssl that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants