Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbs inline ASM IAR: fix register clobber list #7221

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

SparkiDev
Copy link
Contributor

Description

Change register clobber list so that it reserves the same registers for constants regardless of WOLFSSL_NO_VAR_ASSIGN_REG.

Fixes zd#17225

Testing

./configure '--disable-shared' '--host=armv7m' 'CC=arm-linux-gnueabi-gcc' 'LDFLAGS=--static' '--enable-armasm=inline' 'CFLAGS=-DWOLFSSL_NO_VAR_ASSIGN_REG'
And with IAR Workbench.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

Change register clobber list so that it reserves the same registers for
constants regardless of WOLFSSL_NO_VAR_ASSIGN_REG.
@SparkiDev SparkiDev self-assigned this Feb 7, 2024
Copy link
Contributor

@josepho0918 josepho0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unnecessary alignment XALIGNED(16) can be removed from AES and SHA tables.

@SparkiDev SparkiDev assigned dgarske and wolfSSL-Bot and unassigned SparkiDev Feb 7, 2024
@SparkiDev
Copy link
Contributor Author

I'll leave the alignment to potentially make it quicker to read the tables as there will definitely be no alignment issues.

@dgarske dgarske merged commit 7e14258 into wolfSSL:master Feb 7, 2024
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants