Apache httpd w/TLS 1.3 support #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndshake` for the server-side to support rehandshake. Required for Apache v2.4.39 with TLS v1.3.
SparkiDev
requested changes
Oct 26, 2020
| } | ||
| #endif | ||
| #ifndef NO_WOLFSSL_CLIENT | ||
| if (ssl->options.side == WOLFSSL_CLIENT_END) { |
There was a problem hiding this comment.
OpenSSL returns an error when client side.
| @@ -10357,6 +10357,30 @@ void wolfSSL_set_verify_result(WOLFSSL *ssl, long v) | |||
| #endif | |||
| } | |||
|
|
|||
| /* For TLS v1.3 perform rehandshake. Returns 1=WOLFSSL_SUCCESS or 0=WOLFSSL_FAILURE */ | |||
There was a problem hiding this comment.
Not a rehandshake - sending handshake messages after handshake complete.
| #endif | ||
| #ifndef NO_WOLFSSL_CLIENT | ||
| if (ssl->options.side == WOLFSSL_CLIENT_END) { | ||
| ret = wolfSSL_allow_post_handshake_auth(ssl); |
There was a problem hiding this comment.
Looks like SSL_[CTX_]set_post_handshake_auth() enables/disables.
…th` and `SSL_set_post_handshake_auth` API's for enabling or disabling post handshake authentication for TLS v1.3.
haydenroche5
reviewed
Nov 5, 2020
| return (ret == 0) ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE; | ||
| } | ||
|
|
||
| void wolfSSL_CTX_set_post_handshake_auth(WOLFSSL_CTX* ctx, int val) |
There was a problem hiding this comment.
I think the return type should be int for this guy and wolfSSL_set_post_handshake_auth.
…nd do a return code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL_verify_client_post_handshakefor the server-side to support rehandshake (Required for Apache v2.4.39 with TLS v1.3)SSL_CTX_set_post_handshake_authandSSL_set_post_handshake_authAPI's for enabling or disabling post handshake authentication for TLS v1.3OPENSSL_init_cryptoandOPENSSL_init_sslAPI's.